[ofa-general] Re: [PATCH] libibmad: Declare some enums as typedefs for cleaner function interfaces

[Ira Weiny]

On Wed, 4 Feb 2009 20:27:25 +0200
Sasha Khapyorsky <sashak at voltaire.com> wrote:

> On 11:20 Wed 04 Feb     , Jason Gunthorpe wrote:
> > On Wed, Feb 04, 2009 at 08:14:21PM +0200, Sasha Khapyorsky wrote:
> > 
> > > I don't understand how enum typedefing makes things cleaner - actually
> > > this will enforce me explicitly to verify an actual type in header
> > > files. Sometimes typedefs could help with porting, but it is not the
> > > case here.
> > 
> > Not typedefing per say, but passing an enum through an int is not that
> > great. You don't need the typedefs to do this, just 'enum MAD_FIELDS'
> > for instance will do.
> 
> Yes, that would be fine to do.

I will redo the patch with 'enum MAD_FIELDS'.

Ira

> 
> Sasha