[ofa-general] Re: [PATCH][TRIVIAL] opensm/osm_node.h: osm_node_get_num_physp description fix

[Sasha Khapyorsky]

On 15:03 Wed 04 Feb     , Hal Rosenstock wrote:
> >
> > For switch it will be an actual number of allocated physical ports
> > (struct osm_physp) - port 0 olus number of external ports. For non
> > switch nodes entry '0' is not used.
> 
> Right. In my terms, physical is another name for an external port and
> port 0 is not a physical (external) port so I think we're quibbling
> about words. What do you think it should say ?

I don't really have a good opinion :(. Maybe something like:

 *	Returns the number of osm_physp ports allocated for this for node
 *	(for switches it is number of external physical ports plus port
 *	0 and number of physical ports + 1 for non-switch nodes).

It is long... :(

Sasha