[ofa-general] Re: [PATCH 1 of 2 for 2.6.28] core: Fix Raw Ethertype QP support

[Roland Dreier]

 > @@ -752,6 +752,11 @@ struct ib_send_wr {
 >  			int				access_flags;
 >  			u32				rkey;
 >  		} fast_reg;
 > +		struct {
 > +			struct ib_unpacked_lrh	*lrh;
 > +			u32			eth_type;
 > +			u8			static_rate;
 > +		} raw_ety;

Would it be more sensible to make eth_type __be16, since it's limited to
16 bits, and ethertype is usually specified in network endian?

Also rather than an LRH structure, would it make more sense to give
dlid, source path bits and service level?  Otherwise it seems the
consumer needs to keep track of the port's assigned LID to make sure the
SLID field is correct (not to mention computing packet length, setting
LNH properly, etc).


It seems there are some changes needed to the ib_wc structure to be able
to return the ethertype on receive?

 - R.