[ofa-general] Re: [PATCH OpenSM 0/3] Fat Tree - Routing between non-CN nodes

[Nicolas Morey Chaisemartin]

Sasha Khapyorsky wrote:
> On 20:48 Sat 07 Feb     , Nicolas Morey-Chaisemartin wrote:
>   
>>> "IO" is specific for your setup. Could we find more generic name for such
>>> nodes?
>>>
>>>   
>>>       
>> Sure. Any ideas?
>>     
>
> No, I didn't think about it.
>
>   
>>
>> Okay, I'll fix the indentation and few coding style error. There is also
>> a bug in the current patch as the hops counter are not set to the right
>> value when creating route which had reverse hops number of reverse
>> hops*2 should be added.
>>
>> I'll have to rewrite the patches so they work with the current HEAD.
>> Specially with the option system changes it won't merge cleanly.
>>     
>
> Use 'git-rebase master <yourbranch>' - it does the job with only two
> trivial conflicts.
>
> Sasha
>
>
>   
Well I still need to rename the option, fix the hop counts but most of 
all it will conflict (and bug) with the fix I've just reposted about 
port incrementation (reverse_hop also has boolean value to return which 
it doesn't right now).
I have one working in Bull tree but there has been to many modifications 
in the code around to merge it cleanly.
I'll rewrite it cleanly as soon as I got some time.

Nicolas