[ofa-general] [PATCH 2.6.30] RDMA/cxgb3: Remove modulo math.

Roland Dreier rdreier at cisco.com
Wed Feb 11 10:12:09 PST 2009


 > Note that wr->sg_list[i].addr was being cast to a u32.  That was wrong.

Is it possible for the page to be bigger than 4GB?  If so then yes you
might be chopping off high-order bits or something.

Anyway please send me this change as a separate patch with a changelog
explaining that you're avoiding the div etc.... I don't want to roll it
in with the other unrelated fix (which changes code that was never
upstream anyway).



More information about the general mailing list