[ofa-general] Re: [PATCH] IPoIB: In unicast_arp, do path_free only for newly-created paths

Jack Morgenstein jackm at dev.mellanox.co.il
Tue Feb 17 23:13:15 PST 2009


On Wednesday 18 February 2009 00:54, Roland Dreier wrote:
>  > Signed-off-by: Jack Morgenstein <jackm at dev.mellanox.co.il>
>  > Signed-off-by: Moni Shua <monis at voltaire.com>
> 
> This doesn't make any sense... Moni was not involved in sending this
> patch at all, and in any case since you are sending the patch your s-o-b
> should be last.  If you want to give credit to Moni then include it in
> the description as you did for Yossi.
> 

Yossi identified the problem flow. I wrote and tested the actual patch.
Moni reviewed it, and I wrote the final version. I always thought that
the first s-o-b was for the patch writer. Next time, I'll do it right.



More information about the general mailing list