[ofa-general] [PATCH 4/10] infiniband-diags: Convert ibportstate to "new" ibmad interface

Ira Weiny weiny2 at llnl.gov
Fri Feb 20 13:51:44 PST 2009


On Fri, 20 Feb 2009 10:28:13 -0800
Ira Weiny <weiny2 at llnl.gov> wrote:

> On Fri, 20 Feb 2009 08:42:31 -0500
> Hal Rosenstock <hal.rosenstock at gmail.com> wrote:
> 
> > On Thu, Feb 19, 2009 at 10:05 PM, Ira Weiny <weiny2 at llnl.gov> wrote:
> > > >From 9ae029eec58963629f4713868f383c6dd651448d Mon Sep 17 00:00:00 2001
> > > From: Ira Weiny <weiny2 at llnl.gov>
> > > Date: Thu, 19 Feb 2009 17:27:21 -0800
> > > Subject: [PATCH] infiniband-diags: Convert ibportstate to "new" ibmad interface
> > >
> > >
> > > Signed-off-by: Ira Weiny <weiny2 at llnl.gov>
> > > ---
> > >  infiniband-diags/src/ibportstate.c |   18 ++++++++++++------

<snip>

> > >
> > > -       madrpc_init(ibd_ca, ibd_ca_port, mgmt_classes, 3);
> > > +       srcport = mad_rpc_open_port(ibd_ca, ibd_ca_port, mgmt_classes, 3);
> > > +       if (!srcport)
> > > +               IBERROR("Failed to open '%s' port '%d'", ibd_ca, ibd_ca_port);
> > 
> > Is this missing the corresponding close_port ? Same for some of the
> > subsequent patches.
> 
> Yep I missed a couple of them.  4/10, 6/10, and 9/10.  New patches to follow.
> 
> Ira
> 

Nope 9/10 does not require this as it uses umad to close the port.  The 2
new patches for 4/10 and 6/10 follow.

Ira




More information about the general mailing list