[ofa-general] Re: [PATCH v2] [ib-diag] saquery: add support for WinOF

Sasha Khapyorsky sashak at voltaire.com
Fri Feb 27 00:32:00 PST 2009


On 15:10 Thu 26 Feb     , Sean Hefty wrote:
> Signed-off-by: Sean Hefty <sean.hefty at intel.com>

All applied. Thanks.

>   - modify CHECK_AND_SET_VAL - comparison is done as signed, but assignments
>     are unsigned.  This is kind of confusing, but that's how it appears the
>     macro is used.  It might be clearer if instead of passing -1 into the
>     macro, that a SET_VAL macro be used instead.

What do you mean? Another macro?

Sasha



More information about the general mailing list