***SPAM*** Re: [ofa-general] Re: [PATCH] ibsim/umad2sim.c: Eliminate unneeded umad2sim_dev num

[Hal Rosenstock]

Sasha,

On Fri, Feb 27, 2009 at 4:08 AM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
> Hi Hal,
>
> On 12:44 Thu 19 Feb     , Hal Rosenstock wrote:
>>
>> Signed-off-by: Hal Rosenstock <hal.rosenstock at gmail.com>
>> ---
>> diff --git a/umad2sim/umad2sim.c b/umad2sim/umad2sim.c
>> index e13e30a..aaa6260 100644
>> --- a/umad2sim/umad2sim.c
>> +++ b/umad2sim/umad2sim.c
>> @@ -1,5 +1,6 @@
>>  /*
>>   * Copyright (c) 2006-2008 Voltaire, Inc. All rights reserved.
>> + * Copyright (c) 2009 HNR Consulting. All rights reserved.
>>   *
>>   * This file is part of ibsim.
>>   *
>> @@ -77,7 +78,6 @@ struct ib_user_mad_reg_req {
>>
>>  struct umad2sim_dev {
>>       int fd;
>> -     unsigned num;
>
> Wouldn't it be useful when more than one CA/host ports will be supported
> using umad2sim?

Then shouldn't it be added at the time that that feature is supported
rather than have the currently unneeded initialization ?

-- Hal

> Sasha