[ofa-general] Re: [PATCH 2/2] perfquery: add PortXmtDataSL/PortRcvDataSL read and reset

[Sasha Khapyorsky]

Hi Or,

On 14:41 Thu 26 Feb     , Or Gerlitz wrote:
> 
> For some reason the Xmt SL help is printed twice, any idea why?

Yes. You added '-s' option, but 's' letter is used already by
ibdiag_common:

Usage: perfquery [options]  [<lid|guid> [[port] [reset_mask]]]

Options:
  --extended, -x          show extended port counters
  --all_ports, -a         show aggregated counters
  --loop_ports, -l        iterate through each port
  --reset_after_read, -r  reset counters after read
  --Reset_only, -R        only reset counters
  --Ca, -C <ca>           Ca name to use
  --Port, -P <port>       Ca port number to use
  --Lid, -L               use LID address argument
  --Guid, -G              use GUID address argument
  --timeout, -t <ms>      timeout in ms
  --sm_port, -s <lid>     SM port lid
  ^^^^^^^^^^^^^^^
  ...


You can mask it by passing 's' as part of exclude string to
ibdiag_process_opts(). Or just find another, "free" latter for your
option.

Sasha