[ofa-general] Re: [PATCH] opensm/osm_port_info_rcv.c: don't clear sw->need_update if port 0 is active

Sasha Khapyorsky sashak at voltaire.com
Wed Jan 7 08:25:14 PST 2009


On 10:57 Thu 01 Jan     , Yevgeny Kliteynik wrote:
> 
> When switch is coming up after reset, port 0 always reports
> logical state ACTIVE.
> OpenSM shouldn't clear sw->need_update flag because of port 0.
> 
> Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>

Applied. Thanks.

BTW is it legal from IBA point of view for switch to setup logical state
of port 0 without SM intervention after reset?

Sasha

> ---
>  opensm/opensm/osm_port_info_rcv.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/opensm/opensm/osm_port_info_rcv.c b/opensm/opensm/osm_port_info_rcv.c
> index 8763b87..02ad586 100644
> --- a/opensm/opensm/osm_port_info_rcv.c
> +++ b/opensm/opensm/osm_port_info_rcv.c
> @@ -317,7 +317,7 @@ __osm_pi_rcv_process_switch_port(IN osm_sm_t * sm,
>  	}
> 
>  	if (ib_port_info_get_port_state(p_pi) > IB_LINK_INIT && p_node->sw &&
> -	    p_node->sw->need_update == 1)
> +	    p_node->sw->need_update == 1 && port_num != 0)
>  		p_node->sw->need_update = 0;
> 
>  	if (p_physp->need_update)
> -- 
> 1.5.1.4
> 



More information about the general mailing list