[ofa-general] Re: [PATCH] ib_mthca: Fix dispatch of IB_EVENT_LID_CHANGE

Roland Dreier rdreier at cisco.com
Wed Jan 28 15:16:06 PST 2009


Thanks, applied this and the mlx4 change.

Comments on the changelog

 > This patch dispatches an event if the client_reregister bit is set.
 > In addition, the patch compares the LID in the MAD to the current LID.
 > If and only if they are not identical then a LID_CHANGE event is dispatched.
 > 
 > From: Moni Shoua <monis at voltaire.com>

"From:" lines go *before* the changelog, not after, otherwise they get
stuck into the git log rather than used as the patch author.

 > Signed-off-by: Moni Shoua <monis at voltaire.com>
 > Signed-off-by: Jack Morgenstein <jackm at dev.mellanox.co.il>
 > Signed-off-by: Yossi Etigin <yosefe at voltaire.com>
 > 
 > --

Need three dashes like "---", not just two for git to treat it as the
end of the changelog.  "--" gets put into the git log rather than being
stripped.

 - R.



More information about the general mailing list