***SPAM*** Re: [ofa-general] [PATCH 11/10] libibmad:infiniband-diags: deprecate madrpc_set_[retries|timeout] WAS: [PATCH 1/10] libibmad: Clean up "new" interface

[Hal Rosenstock]

On Sun, Mar 1, 2009 at 2:26 AM, Sasha Khapyorsky <sashak at voltaire.com> wrote:

[snip...]

> Now you need to duplicate this single call over all tools. For me it
> looks like an overkill.

See below.

> Probably it would be simpler to just read global
> ibd_timeout variable in rpc.c?

[snip...]

> Same with retries - it is hard for me to believe that any multithreaded
> application will try to setup different retry values per port, for
> different threads, "on the fly"....

For timeouts and retries, per port makes sense to me as ports may be
connected to different fabrics with different timeouts. Also, it may
depend on the operation (e.g. restricted to a single subnet or across
multiple subnets).

> (rpc.c with all its limited functionality will not be sufficient for such flexibility
> level anyway :)).

This would be an implementation issue to fix if the more flexible
timeout/retries is to be implemented.

-- Hal