[ofa-general] Re: [PATCH 2/10] infiniband-diags: Convert ibaddr to "new" ibmad interface

[Sasha Khapyorsky]

On 16:06 Mon 02 Mar     , Ira Weiny wrote:
> > > diff --git a/infiniband-diags/src/ibdiag_common.c b/infiniband-diags/src/ibdiag_common.c
> > > index 5f2472d..609df69 100644
> > > --- a/infiniband-diags/src/ibdiag_common.c
> > > +++ b/infiniband-diags/src/ibdiag_common.c
> > > @@ -179,7 +179,8 @@ static int process_opt(int ch, char *optarg)
> > >  		ibd_timeout = val;
> > >  		break;
> > >  	case 's':
> > > -		if (ib_resolve_portid_str(&sm_portid, optarg, IB_DEST_LID, 0) < 0)
> > > +		if (ib_resolve_portid_str_via(&sm_portid, optarg, IB_DEST_LID,
> > > +				0, NULL) < 0)
> > 
> > This may be not correct (not introduced by those patches) - then host is
> > connected to multiple subnets we need to resolve SM LID on requested
> > one, eg. using srcport...
> > 
> 
> Would you accept adding srcport to ibdiag_process_opts?  Or would you prefer
> something more generic?

More generic would be better :)

BTW it could be not so easy - when ibdiag_process_opts() is running
srcport is not initialized yet.

Sasha