[ofa-general] Re: [PATCH v2 1/2] opensm: Handle trap repress on trap 144 generation

Sasha Khapyorsky sashak at voltaire.com
Tue Mar 10 08:37:54 PDT 2009


On 13:19 Fri 06 Mar     , Hal Rosenstock wrote:
> 
> Make trap generation sending be a transaction (expect a response)
> and handle incoming trap repress (notice attribute)
> ib_mad_is_response is now changed to better reflect responses
> (not just R bit in MAD header)
> 
> Signed-off-by: Hal Rosenstock <hal.rosenstock at gmail.com>

Applied with discussed changes (also see below). Thanks.

> @@ -624,10 +675,14 @@ __osm_sm_mad_ctrl_rcv_callback(IN osm_madw_t * p_madw,
>  		__osm_sm_mad_ctrl_process_set(p_ctrl, p_madw);
>  		break;
>  
> +	case IB_MAD_METHOD_TRAP_REPRESS:
> +		CL_ASSERT(p_req_madw == NULL);

It is response, so should be CL_ASSERT(p_req_madw != NULL).

Sasha



More information about the general mailing list