***SPAM*** Re: [ofa-general] ***SPAM*** [PATCH] infiniband-diags/mcm_rereg_test.c: Add missing mad_rpc_close_port call

Sean Hefty sean.hefty at intel.com
Thu Mar 12 10:07:10 PDT 2009


>Someone made the decision to want to be able to switch back and forth
>earlier. This should be directed to them. It's certainly easy to
>eliminate the old code.

I'm wasn't suggesting that you fix the existing code, just not add to it.

If someone wants to be able to switch back and forth, it makes way more sense to
use an #if something_that_can_be_set_during_the_build, than #if 1, which
requires source code changes in multiple places.




More information about the general mailing list