[ofa-general] Re: [PATCH] infiniband-diags: Fix memory leaks on IBERROR and IBPANIC

[Hal Rosenstock]

On Thu, Mar 12, 2009 at 12:35 PM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
> On 11:55 Thu 12 Mar     , Hal Rosenstock wrote:
>>
>> Since these macros exit, now need to call mad_rpc_close_port
>> prior to invoking them
>
> Both IBERROR and IBPANIC calls exit(), it closes all opened files. This
> patch looks like an overkill.

It's not a matter of relying on exit for open fds but rather the
allocated memory under the covers of mad_rpc_open_port so no longer
can one rely on just exit and this needs to be made explicit.

-- Hal

> Sasha
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>