[ofa-general] Re: [PATCH v2] opensm/osm_ucast_ftree.c: some refactoring

[Sasha Khapyorsky]

Hi Yevgeny,

On 01:04 Fri 13 Mar     , Yevgeny Kliteynik wrote:
> 
> +/***************************************************/
> +
> +static int
> +set_hops_on_remote_sw(IN ftree_port_group_t * p_group,
> +		      IN ib_net16_t target_lid,
> +		      IN uint8_t hops)
> +{
> +	ftree_port_t * p_port;
> +	uint8_t i, ports_num;
> +	ftree_sw_t * p_remote_sw = p_group->remote_hca_or_sw.p_sw;
> +
> +	CL_ASSERT(p_group->remote_node_type == IB_NODE_TYPE_SWITCH);
> +	ports_num = (uint8_t) cl_ptr_vector_get_size(&p_group->ports);
> +	for (i = 0; i < ports_num; i++) {
> +		cl_ptr_vector_at(&p_group->ports, i, (void *)&p_port);
> +		if (sw_set_hops(p_remote_sw, cl_ntoh16(target_lid),
> +				p_port->remote_port_num, hops));

Should ';' be here at end of if()?

Sasha

> +			return -1;
> +	}
> +	return 0;
> +}
> +
>  /***************************************************
>   **
>   ** ftree_hca_t functions