[ofa-general][PATCH 2/2 V2] mlx4_core: Link sensing support

Roland Dreier rdreier at cisco.com
Wed Mar 18 19:45:59 PDT 2009


 > +			if ((port_type[i] == MLX4_PORT_TYPE_ETH) ||
 > +			    (port_type[i+1] == MLX4_PORT_TYPE_IB))

seems there is a typo here -- should be && instead of ||.  I fixed this
by hand but I'm wondering how much testing this version of the patch
got...

 > +			dev->caps.supported_type[i] == MLX4_PORT_TYPE_AUTO ? 1 : 0;

I never understand why people write

	(boolean expression) ? 1 : 0;

since the boolean expression is already 1 or 0 anyway.  I fixed this.

Anyway, applied, thanks.



More information about the general mailing list