***SPAM*** Re: [ofa-general] Re: [PATCH] libibmad: Add PortSelect and CounterSelect fields for PortXmit/RcvDataSL attributes

[Hal Rosenstock]

On Fri, Mar 20, 2009 at 9:27 PM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
> On 10:07 Fri 20 Mar     , Hal Rosenstock wrote:
>>
>> It does eliminate the duplication in ib_mad_f but add additional calls
>> to mad_dump_perfcounters_xmt/rcv_sl. Is that really better ?
>
> There are no such calls, at least not now.

Huh ? They already exist in libibmad/src/dump.c, added by Or.

Anyhow, the difference is minor and it's six of one half dozen of
other and you have both approaches in patches so you can decide.

-- Hal

> Sasha
>