[ofa-general][PATCH] NFS-RDMA fix for connectX fast registration wr,

[Vu Pham]

Tom Talpey wrote:
> At 05:14 PM 3/23/2009, Vu Pham wrote:
>   
>> Tom Talpey wrote:
>>     
>>> At 03:13 PM 3/23/2009, Tziporet Koren wrote:
>>>   
>>>       
>>>> Vu Pham wrote:
>>>>     
>>>>         
>>>>> The patch does not work with old FW.
>>>>> The old fw set the bit; however, it has bug on FRWR
>>>>>
>>>>>       
>>>>>           
>>>> But I think we have to push the new code
>>>> A drop of the FW with a fix is already available and it will be GA in 
>>>> few months
>>>>     
>>>>         
>>> I don't fully understand - do you mean the need for setting the
>>> LOCAL_WRITE bit goes away with this upcoming ConnectX firmware?
>>>   
>>>       
>> No - the setting for LOCAL_WRITE bit will still be needed for this 
>> upcoming ConnectX FW.
>>     
>
> Ok, two question in that case...
>
> 1) What's the firmware fix that Tziporet mentions actually for?
>   

A FW bug on Fast registration WR operation

> 2) Is the need for LOCAL_WRITE documented at the FRMR verb layer,
> and do other implementations agree that it's harmless?
>
>   
It is documented in ConnectX's PRM (Program Reference Manual)
Jon already verify the patch and it's harmless to Chelsio.

-vu

> Tom.
>
>   
>>     
>>> In other words, the NFS/RDMA is correct, currently, and Vu's patch
>>> is therefore purely a workaround for a firmware bug?
>>>
>>> I feel differently about pushing this fix upstream, if so.
>>>
>>> Tom.
>>>
>>>   
>>>       
>>     
>
>