[ofa-general] Re: [PATCH 8/8] Convert ibqueryerrors.pl to C and use new ibnetdisc library.

Sasha Khapyorsky sashak at voltaire.com
Fri May 1 11:55:08 PDT 2009


On 14:50 Mon 27 Apr     , Ira Weiny wrote:
> 
> The removal of this line causes the '-S' option to segfault.  Patch to pq/ibn4
> is below.

Thanks. I'm applying this to pq/ibn4

> I will work up a separate patch.  Right now you are correct if the SA is
> unresponsive the "-S" option will fail.  iblinkinfo does the full scan every
> time.  But that slows down the query for a single switch to the same O(n)
> query that a full system scan requires.  I would rather have that query be
> O(1).  So I implemented ibqueryerrors in this manner with the intent of going
> back and "fixing" iblinkinfo.  I think having a fall back on a full system
> scan is a good idea.  Patch for both tools will follow...  :-D

Thanks. I'm doing pq/ibn4 merge now. We can apply the rest after this.

Sasha



More information about the general mailing list