[ofa-general] Re: [PATCH] 'ibcheckportwidth' : Exit if LWS is 1X

Sasha Khapyorsky sashak at voltaire.com
Sat Sep 19 11:08:26 PDT 2009


On 09:12 Wed 16 Sep     , Keshetti Mahesh wrote:
> Fix: Modify ibcheckportwidth to exit if LWS is 1X instead of processing
> next lines.
> Trivial: ibcheckportwidth man page cosmetic change

Again, the patch is malformed. Please verify the patches before
submission.

> 
> Signed-off-by: Keshetti Mahesh <keshetti.mahesh at gmail.com>
> ---
> infiniband-diags/man/ibcheckportwidth.8      |    2 +-
> infiniband-diags/scripts/ibcheckportwidth.in |    2 +-
> 
> diff --git a/infiniband-diags/man/ibcheckportwidth.8
> b/infiniband-diags/man/ibcheckportwidth.8
> index 85c06fc..c368467 100644
> --- a/infiniband-diags/man/ibcheckportwidth.8
> +++ b/infiniband-diags/man/ibcheckportwidth.8
> @@ -4,7 +4,7 @@
>  ibcheckportwidth \- validate IB port for 1x link width
> 
>  .SH SYNOPSIS
> -.B ibcheckport
> +.B ibcheckportwidth
>  [\-h] [\-v] [\-N | \-nocolor] [\-G] [\-C ca_name] [\-P ca_port]
>  [\-t(imeout) timeout_ms]  <lid|guid> <port>
> 

This chunk appears already in the previous patch.

> diff --git a/infiniband-diags/scripts/ibcheckportwidth.in
> b/infiniband-diags/scripts/ibcheckportwidth.in
> index 32c5c5e..60a0892 100644
> --- a/infiniband-diags/scripts/ibcheckportwidth.in
> +++ b/infiniband-diags/scripts/ibcheckportwidth.in
> @@ -103,7 +103,7 @@ function blue(s)
>  }
> 
>  # Only check LinkWidthActive if LinkWidthSupported is not 1X
> -/^LinkWidthSupported/{ if ($2 != "1X") { next } }
> +/^LinkWidthSupported/{ if ($2 == "1X") { exit } }

Applied (by hands). Thanks.

Sasha

> --
> 1.6.4.2
> 
> --
> Keshetti Mahesh
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 



More information about the general mailing list