[ofa-general] Re: [PATCH] osmtest: Add SA get PathRecord stress test

[Hal Rosenstock]

Hi Sasha,

On Sun, Sep 20, 2009 at 6:20 AM, Sasha Khapyorsky <sashak at voltaire.com>wrote:

<snip...>

> diff --git a/opensm/osmtest/osmtest.c b/opensm/osmtest/osmtest.c
> index 986a8d2..8357d90 100644
> --- a/opensm/osmtest/osmtest.c
> +++ b/opensm/osmtest/osmtest.c

<snip...>

> +
> +     /*
> +      * Do a blocking query for the PathRecord.
> +      */
> +     status = osmtest_get_path_rec_by_lid_pair(p_osmt, slid, dlid,
&context);
> +     if (status != IB_SUCCESS) {
> +             OSM_LOG(&p_osmt->log, OSM_LOG_ERROR, "ERR 000A: "
> +                     "osmtest_get_path_rec_by_lid_pair failed (%s)\n",
> +                     ib_get_err_str(status));
> +             goto Exit;
> +     }

It is not really "stress" testing, just pinging.


So are the other tests (additionally those use RMPP). Isn't repetitive
pinging a stress of a kind ?


> Shouldn't it be clarified in test description?


Same level of description as other tests. They all could be made more
descriptive.

-- Hal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20090921/e9fc87c9/attachment.html>