<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>RE: [openib-general] [PATCH] OpenSM - Multiple Initializations of objects on startup</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>Committed to OpenSM - gen1.</FONT>
<BR><FONT SIZE=2>Thanks,</FONT>
<BR><FONT SIZE=2>Yael</FONT>
</P>
<P><FONT SIZE=2>-----Original Message-----</FONT>
<BR><FONT SIZE=2>From: Jan Daley [<A HREF="mailto:jdaley@systemfabricworks.com">mailto:jdaley@systemfabricworks.com</A>]</FONT>
<BR><FONT SIZE=2>Sent: Saturday, August 07, 2004 12:09 AM</FONT>
<BR><FONT SIZE=2>To: openib-general@openib.org</FONT>
<BR><FONT SIZE=2>Subject: [openib-general] [PATCH] OpenSM - Multiple Initializations of</FONT>
<BR><FONT SIZE=2>objects on startup</FONT>
</P>
<BR>
<P><FONT SIZE=2>Hi,</FONT>
</P>
<P><FONT SIZE=2>osm_subn_construct and cl_map_init(&(p_subn->opt.port_pro_ignore_guids),</FONT>
<BR><FONT SIZE=2>10) are being called twice. This causes some memory leaks. </FONT>
</P>
<BR>
<P><FONT SIZE=2>Index: opensm/osm_subnet.c</FONT>
<BR><FONT SIZE=2>===================================================================</FONT>
<BR><FONT SIZE=2>--- opensm/osm_subnet.c (revision 590)</FONT>
<BR><FONT SIZE=2>+++ opensm/osm_subnet.c (working copy)</FONT>
<BR><FONT SIZE=2>@@ -112,7 +112,6 @@</FONT>
<BR><FONT SIZE=2> cl_qmap_init( &p_subn->rtr_guid_tbl );</FONT>
<BR><FONT SIZE=2> cl_qmap_init( &p_subn->prtn_pkey_tbl );</FONT>
<BR><FONT SIZE=2> cl_qmap_init( &p_subn->mgrp_mlid_tbl );</FONT>
<BR><FONT SIZE=2>- cl_map_init(&(p_subn->opt.port_pro_ignore_guids), 10);</FONT>
<BR><FONT SIZE=2> cl_list_construct( &p_subn->new_ports_list );</FONT>
<BR><FONT SIZE=2> cl_list_init( &p_subn->new_ports_list, 10 );</FONT>
<BR><FONT SIZE=2> }</FONT>
<BR><FONT SIZE=2>@@ -200,8 +199,6 @@</FONT>
<BR><FONT SIZE=2> {</FONT>
<BR><FONT SIZE=2> cl_status_t status;</FONT>
<BR><FONT SIZE=2> </FONT>
<BR><FONT SIZE=2>- osm_subn_construct( p_subn );</FONT>
<BR><FONT SIZE=2>-</FONT>
<BR><FONT SIZE=2> status = cl_ptr_vector_init( &p_subn->node_lid_tbl,</FONT>
<BR><FONT SIZE=2> OSM_SUBNET_VECTOR_MIN_SIZE,</FONT>
<BR><FONT SIZE=2> OSM_SUBNET_VECTOR_GROW_SIZE );</FONT>
</P>
<BR>
<BR>
<BR>
<BR>
<P><FONT SIZE=2>Jan Daley</FONT>
<BR><FONT SIZE=2>System Fabric Works</FONT>
<BR><FONT SIZE=2>(512) 343-6101 x 13</FONT>
</P>
<BR>
<BR>
<BR>
<P><FONT SIZE=2>_______________________________________________</FONT>
<BR><FONT SIZE=2>openib-general mailing list</FONT>
<BR><FONT SIZE=2>openib-general@openib.org</FONT>
<BR><FONT SIZE=2><A HREF="http://openib.org/mailman/listinfo/openib-general" TARGET="_blank">http://openib.org/mailman/listinfo/openib-general</A></FONT>
</P>
<P><FONT SIZE=2>To unsubscribe, please visit <A HREF="http://openib.org/mailman/listinfo/openib-general" TARGET="_blank">http://openib.org/mailman/listinfo/openib-general</A></FONT>
</P>
</BODY>
</HTML>