<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>RE: OpenSM: osm_sa_path_record.c minor code redundancy</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>Correct. The first one should be removed.</FONT>
</P>
<P><FONT SIZE=2>Eitan Zahavi</FONT>
<BR><FONT SIZE=2>Design Technology Director</FONT>
<BR><FONT SIZE=2>Mellanox Technologies LTD</FONT>
<BR><FONT SIZE=2>Tel:+972-4-9097208</FONT>
<BR><FONT SIZE=2>Fax:+972-4-9593245</FONT>
<BR><FONT SIZE=2>P.O. Box 586 Yokneam 20692 ISRAEL</FONT>
</P>
<BR>
<P><FONT SIZE=2>-----Original Message-----</FONT>
<BR><FONT SIZE=2>From: Hal Rosenstock [<A HREF="mailto:halr@voltaire.com">mailto:halr@voltaire.com</A>] </FONT>
<BR><FONT SIZE=2>Sent: Wednesday, January 19, 2005 6:10 PM</FONT>
<BR><FONT SIZE=2>To: Eitan Zahavi</FONT>
<BR><FONT SIZE=2>Cc: openib-general@openib.org</FONT>
<BR><FONT SIZE=2>Subject: OpenSM: osm_sa_path_record.c minor code redundancy</FONT>
</P>
<P><FONT SIZE=2>Hi Eitan,</FONT>
</P>
<P><FONT SIZE=2>It looks to me like in osm_sa_path_record.c::__osm_pr_rcv_respond that</FONT>
<BR><FONT SIZE=2>the second setting of NO RECORDS status is redundant as it is weeded out</FONT>
<BR><FONT SIZE=2>earlier in that routine.</FONT>
</P>
<P><FONT SIZE=2> if( num_rec == 0 )</FONT>
<BR><FONT SIZE=2> {</FONT>
<BR><FONT SIZE=2> osm_sa_send_error( p_rcv->p_resp, p_madw,</FONT>
<BR><FONT SIZE=2> IB_SA_MAD_STATUS_NO_RECORDS );</FONT>
<BR><FONT SIZE=2> goto Exit;</FONT>
<BR><FONT SIZE=2> }</FONT>
<BR><FONT SIZE=2>...</FONT>
<BR><FONT SIZE=2> if( num_rec == 0 )</FONT>
<BR><FONT SIZE=2> {</FONT>
<BR><FONT SIZE=2> p_resp_sa_mad->status = IB_SA_MAD_STATUS_NO_RECORDS;</FONT>
<BR><FONT SIZE=2> cl_memclr( p_resp_pr, sizeof(*p_resp_pr) );</FONT>
<BR><FONT SIZE=2> }</FONT>
<BR><FONT SIZE=2> else</FONT>
<BR><FONT SIZE=2> {</FONT>
<BR><FONT SIZE=2>...</FONT>
</P>
<P><FONT SIZE=2>-- Hal</FONT>
</P>
</BODY>
</HTML>