<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>RE: [PATCH] ibdm nits and a few questions</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>Hi Ber,</FONT>
</P>
<P><FONT SIZE=2>Thanks for the patch and the word list. I will apply these right away.</FONT>
</P>
<P><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> What about removing all the generated scripts (configure et al) and</FONT>
<BR><FONT SIZE=2>> auto-tools helpers (aclocal.m4 etc and most of config/*) from the</FONT>
<BR><FONT SIZE=2>> repository?</FONT>
<BR><FONT SIZE=2>[EZ] I thought I have done that. I will double check.</FONT>
</P>
<P><FONT SIZE=2>> Note that the other userspace IB libraries do not have these in the</FONT>
<BR><FONT SIZE=2>> repository but each do provide a toplevel ./autogen.sh -- as opposed</FONT>
<BR><FONT SIZE=2>> to ibdm's ./config/bootstrap.</FONT>
<BR><FONT SIZE=2>[EZ] We can rename the bootstrap autogen.sh but from what I learned about auto tools many use ./config/bootstrap ...</FONT>
<BR><FONT SIZE=2>Is it really annoying?</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> There are a number of other unused variables.</FONT>
<BR><FONT SIZE=2>[EZ] We should fix all of those! </FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Is ibdm supposed to be compilable with pure ISO c++ compilers, btw?</FONT>
<BR><FONT SIZE=2>> There is at least one place which uses a variable sized array which AFAIK</FONT>
<BR><FONT SIZE=2>> is not valid ISO c++.</FONT>
<BR><FONT SIZE=2>[EZ] I'm not sure what the answer to that is.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> IBMgtSim doesn't compile for me as iba/ib_types.h isn't installed, so</FONT>
<BR><FONT SIZE=2>[EZ] You are missing OpenSM installation on the machine. It is required ... </FONT>
<BR><FONT SIZE=2>You can use --with-osm to point to where it is installed ...</FONT>
</P>
<P><FONT SIZE=2>> the above is only compile-tested.</FONT>
<BR><FONT SIZE=2>[EZ] I will then take the patch manually into the code... (one at a time)</FONT>
</P>
<BR>
</BODY>
</HTML>