<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>RE: [PATCH] ibdm nits and a few questions</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>Hi Ber,</FONT>
</P>
<P><FONT SIZE=2>I plan a huge change in the simulator core. So I do not want to waste your time in cleaning up this code. I have some branch that I use now for debugging.</FONT></P>
<P><FONT SIZE=2>I appreciate your check and contribution but as the code I'm about to commit has many diffs I think it make sense to leave the IBMgtSim for 1 week or so.</FONT></P>
<P><FONT SIZE=2>I also will ispell the code before committing.</FONT>
</P>
<P><FONT SIZE=2>EZ </FONT>
</P>
<P><FONT SIZE=2>Eitan Zahavi</FONT>
<BR><FONT SIZE=2>Design Technology Director</FONT>
<BR><FONT SIZE=2>Mellanox Technologies LTD</FONT>
<BR><FONT SIZE=2>Tel:+972-4-9097208</FONT>
<BR><FONT SIZE=2>Fax:+972-4-9593245</FONT>
<BR><FONT SIZE=2>P.O. Box 586 Yokneam 20692 ISRAEL</FONT>
</P>
<BR>
<P><FONT SIZE=2>> -----Original Message-----</FONT>
<BR><FONT SIZE=2>> From: Bernhard Fischer [<A HREF="mailto:rep.nop@aon.at">mailto:rep.nop@aon.at</A>]</FONT>
<BR><FONT SIZE=2>> Sent: Thursday, July 07, 2005 5:00 PM</FONT>
<BR><FONT SIZE=2>> To: Eitan Zahavi</FONT>
<BR><FONT SIZE=2>> Cc: openib-general@openib.org</FONT>
<BR><FONT SIZE=2>> Subject: Re: [PATCH] ibdm nits and a few questions</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> On Thu, Jul 07, 2005 at 10:15:15AM +0300, Eitan Zahavi wrote:</FONT>
<BR><FONT SIZE=2>> >Hi Ber,</FONT>
<BR><FONT SIZE=2>> ></FONT>
<BR><FONT SIZE=2>> >Thanks for the patch and the word list. I will apply these right away.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> massage -> message</FONT>
<BR><FONT SIZE=2>> randesvous -> rendezvous</FONT>
<BR><FONT SIZE=2>> menager -> manager</FONT>
<BR><FONT SIZE=2>> contant -> content</FONT>
<BR><FONT SIZE=2>> accoumulate -> accumulate</FONT>
<BR><FONT SIZE=2>> somthing -> something</FONT>
<BR><FONT SIZE=2>> Constractor -> Constructor</FONT>
<BR><FONT SIZE=2>> naem -> name</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> ></FONT>
<BR><FONT SIZE=2>> >></FONT>
<BR><FONT SIZE=2>> >> What about removing all the generated scripts (configure et al) and</FONT>
<BR><FONT SIZE=2>> >> auto-tools helpers (aclocal.m4 etc and most of config/*) from the</FONT>
<BR><FONT SIZE=2>> >> repository?</FONT>
<BR><FONT SIZE=2>> >[EZ] I thought I have done that. I will double check.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> In both ibdm,IBMgtSim there is a configure config/share</FONT>
<BR><FONT SIZE=2>> config/libtoolize.</FONT>
<BR><FONT SIZE=2>> ibdm/config/depcomp libtool.m4 install-sh are (or should be) all</FONT>
<BR><FONT SIZE=2>> generated.</FONT>
<BR><FONT SIZE=2>> ></FONT>
<BR><FONT SIZE=2>> >> Note that the other userspace IB libraries do not have these in the</FONT>
<BR><FONT SIZE=2>> >> repository but each do provide a toplevel ./autogen.sh -- as opposed</FONT>
<BR><FONT SIZE=2>> >> to ibdm's ./config/bootstrap.</FONT>
<BR><FONT SIZE=2>> >[EZ] We can rename the bootstrap autogen.sh but from what I learned about</FONT>
<BR><FONT SIZE=2>> >auto tools many use ./config/bootstrap ...</FONT>
<BR><FONT SIZE=2>> >Is it really annoying?</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> It's not consistent, but i don't really care either way.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> >> There are a number of other unused variables.</FONT>
<BR><FONT SIZE=2>> >[EZ] We should fix all of those!</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> IBMgtSim/src/sim.cpp does not compile for me. I tried gcc-3.x as well as</FONT>
<BR><FONT SIZE=2>> 4.x to no avail. Ideas?</FONT>
<BR><FONT SIZE=2>> sim.cpp:201: error: expected `}' at end of input</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> >> Is ibdm supposed to be compilable with pure ISO c++ compilers, btw?</FONT>
<BR><FONT SIZE=2>> >> There is at least one place which uses a variable sized array which AFAIK</FONT>
<BR><FONT SIZE=2>> >> is not valid ISO c++.</FONT>
<BR><FONT SIZE=2>> >[EZ] I'm not sure what the answer to that is.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> I guess it's a question of policy. If gcc can deal with it, it's fine</FONT>
<BR><FONT SIZE=2>> with me, fwiw.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> o IBMSClientInMsgs::proccessClientMsg() strip clientSock which from a</FONT>
<BR><FONT SIZE=2>> short glance seems to be unused.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Attached patch does:</FONT>
<BR><FONT SIZE=2>> in ibmgtsim</FONT>
<BR><FONT SIZE=2>> - turn ibms_disconnect() and ibms_disconnect()) into a void functions</FONT>
<BR><FONT SIZE=2>> - add static in few places</FONT>
<BR><FONT SIZE=2>> - opensm off gen2 doesn't seem to have osm_build_id.h so check for</FONT>
<BR><FONT SIZE=2>> osm_base.h instead</FONT>
<BR><FONT SIZE=2>> - correct offset in configure.in's --enable-debug help text</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Signed-off-by: Bernhard Fischer <rep.nop@aon.at></FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Please review the patch and advise on the sim.cpp compile failure i get</FONT>
<BR><FONT SIZE=2>> with pristine sources.</FONT>
<BR><FONT SIZE=2>> TIA,</FONT>
<BR><FONT SIZE=2>> Bernhard</FONT>
</P>
</BODY>
</HTML>