<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=US-ASCII">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>RE: OpenSM Work</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>Hi Hal,</FONT>
</P>
<P><FONT SIZE=2>Please see my responses below.</FONT>
</P>
<P><FONT SIZE=2>> ></FONT>
<BR><FONT SIZE=2>> > As Mellanox moves to work on OpenIB Gen2 stack, we have assigned Yael</FONT>
<BR><FONT SIZE=2>> > to work on merging OpenSM 1.8.0 (which released based on gen1) into</FONT>
<BR><FONT SIZE=2>> > the gen2 stack.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> I too am working on small pieces of this.</FONT>
<BR><FONT SIZE=2>[EZ] I think it does not make much sense to work in parallel as the changes spans many files. What are the changes you work on?</FONT></P>
<P><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > She has started to work on the merge to ensure that fixes done by you</FONT>
<BR><FONT SIZE=2>> > and Shahar on the gen2 trunk will not be lost.</FONT>
<BR><FONT SIZE=2>> ></FONT>
<BR><FONT SIZE=2>> > The mode of work we suggest is that she will work offline.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Not sure by what you mean by offline here.</FONT>
<BR><FONT SIZE=2>[EZ] Offline means she will do the entire merge and then commit. I propose she will commit the changes into a branch and then you can review it and do the merge to the main trunk yourself.</FONT></P>
<P><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > When the merge will be completed a side branch will be opened under:</FONT>
<BR><FONT SIZE=2>> > <A HREF="https://openib.org/svn/gen2/branches/osm_1_8_0" TARGET="_blank">https://openib.org/svn/gen2/branches/osm_1_8_0</A> and will made available</FONT>
<BR><FONT SIZE=2>> > for review and testing before merge into the main trunk.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> I would prefer small patches rather than a large merge if that were</FONT>
<BR><FONT SIZE=2>> possible.</FONT>
<BR><FONT SIZE=2>[EZ] I am afraid this is impossible due to the large difference in code. The changes affect many files and will require heavy testing to make sure they did not break anything.</FONT></P>
<P><FONT SIZE=2>The testing will be done at the end of the merge work.</FONT>
<BR><FONT SIZE=2>We could however, let her commit small changes - one at a time - but that branch will be useless.</FONT>
</P>
<P><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > Once all this is done, Yael will work on multiple new features</FONT>
<BR><FONT SIZE=2>> > including faster route time, PKey manager, MKey manager, and QoS. She</FONT>
<BR><FONT SIZE=2>> > will do so on branches off the main trunk - for each feature.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> OK. Sounds good.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > In parallel, Liran who owns the OpenSM verification will enhance</FONT>
<BR><FONT SIZE=2>> > osmtest and other testing utilities to achieve better test coverage of</FONT>
<BR><FONT SIZE=2>> > SM handover, SL2VL, VLArb and PKey. Any new feature will get covered</FONT>
<BR><FONT SIZE=2>> > by new tests.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> OK.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > I myself will work on making sure the IB management simulator is well</FONT>
<BR><FONT SIZE=2>> > integrated with the stack</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> What do you mean by stack here ?</FONT>
<BR><FONT SIZE=2>[EZ] I mean OpenIB</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > and the available simulator based tests as well as new tests can be</FONT>
<BR><FONT SIZE=2>> > run daily.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > We do have some issues with respect to the current osm tree:</FONT>
<BR><FONT SIZE=2>> ></FONT>
<BR><FONT SIZE=2>> > 1. All header files were moved from their relative location under</FONT>
<BR><FONT SIZE=2>> > the opensm, complib, iba directories and placed under the include</FONT>
<BR><FONT SIZE=2>> > directory. Although this seems reasonable for a "install" tree - it is</FONT>
<BR><FONT SIZE=2>> > not very common for development trees. Normally I would expect the</FONT>
<BR><FONT SIZE=2>> > Makefile.am of each sub directory of the osm project to define which</FONT>
<BR><FONT SIZE=2>> > header files are to be installed into the $prefix/include dir. We will</FONT>
<BR><FONT SIZE=2>> > revert that hierarchy change in our merged branch.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Are you expecting the reverted hierarchy to make it back to the trunk ?</FONT>
<BR><FONT SIZE=2>[EZ] Yes. Explained why before. If you need examples for how this is done in many other GNU projects we can provide it. </FONT></P>
<P><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > 2. osmtest was just introduced back into the osm tree. I think</FONT>
<BR><FONT SIZE=2>> > osmtest should be placed under a "test" tree where all the tests of</FONT>
<BR><FONT SIZE=2>> > the ULPs core etc will be located. I would expect a location like:</FONT>
<BR><FONT SIZE=2>> ></FONT>
<BR><FONT SIZE=2>> > <A HREF="https://openib.org/svn/gen2/trunk/test/userspace/management/osm" TARGET="_blank">https://openib.org/svn/gen2/trunk/test/userspace/management/osm</A></FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> It can be moved when it is agreed on its location. There are other</FONT>
<BR><FONT SIZE=2>> places being proposed for this (talk to Amit).</FONT>
<BR><FONT SIZE=2>[EZ] OK</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > 3. osmtest needs cleanup from VAPI stuff - we should let Liran</FONT>
<BR><FONT SIZE=2>> > who is the owner of this code development a clear AR to clean it up.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Yes. Can he send patches for this ?</FONT>
<BR><FONT SIZE=2>[EZ] Yes he will</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > 4. For some reason I saw that you have added Voltaire copyright</FONT>
<BR><FONT SIZE=2>> > to the osmtest code. I do not think it makes sense as no work was done</FONT>
<BR><FONT SIZE=2>> > on this code by a Voltaire developer. Or I might be wrong?</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> There was some minor work done in terms of OpenIB. I removed this.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > Needless to say the 1.8.0 version of OpenSM brings with it a long set</FONT>
<BR><FONT SIZE=2>> > of bug fixes and enhancements.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Once the OpenSM work is completed, will OpenSM development by Mellanox</FONT>
<BR><FONT SIZE=2>> be done incrementally and in the open rather than drops ? Will patches</FONT>
<BR><FONT SIZE=2>> be suppplied ?</FONT>
<BR><FONT SIZE=2>[EZ] Yes. After the merge is done all enhancements described above will be done on OpenIB. Assuming we resume our maintainer position and are able to commit directly.</FONT></P>
<P><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> -- Hal</FONT>
</P>
</BODY>
</HTML>