<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=US-ASCII">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>RE: [PATCH ] osmtest general cleanups</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>Hi ,</FONT>
<BR><FONT SIZE=2>Regarding the inform_info test flow , the reason I need (possibly) ib_verbs is to subscribe a notice report through a QP other then QP1 (permitted by IB Spec see p754 , 13.5.1) , generate a trap , then validate the received report through that QP. To enable Set/Recieve notice mads through QP other then QP1 , I think , I need the ib_verbs .</FONT></P>
<P><FONT SIZE=2>Regarding the rest , will be fixed in a seperate patch .</FONT>
</P>
<BR>
<P><FONT SIZE=2>-----Original Message-----</FONT>
<BR><FONT SIZE=2>From: Hal Rosenstock [<A HREF="mailto:halr@voltaire.com">mailto:halr@voltaire.com</A>]</FONT>
<BR><FONT SIZE=2>Sent: Monday, August 08, 2005 3:32 PM</FONT>
<BR><FONT SIZE=2>To: Liran Sorani</FONT>
<BR><FONT SIZE=2>Cc: openib-general@openib.org; Amit Krig</FONT>
<BR><FONT SIZE=2>Subject: RE: [PATCH ] osmtest general cleanups</FONT>
</P>
<BR>
<P><FONT SIZE=2>Hi Liran,</FONT>
</P>
<P><FONT SIZE=2>On Sun, 2005-08-07 at 11:28, Liran Sorani wrote:</FONT>
<BR><FONT SIZE=2>> Hi , Hal.</FONT>
<BR><FONT SIZE=2>> I've a few minor fixes (several white space glitches) , pls take the</FONT>
<BR><FONT SIZE=2>> attached file , instead of the previous ,</FONT>
</P>
<P><FONT SIZE=2>Thanks. Applied with some minor modifications and caveats below.</FONT>
</P>
<P><FONT SIZE=2>In the future can your patches be submitted as text rather than</FONT>
<BR><FONT SIZE=2>attachments ? That is the norm for doing this.</FONT>
</P>
<P><FONT SIZE=2>Some comments below.</FONT>
</P>
<P><FONT SIZE=2>> thanks Liran.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> -----Original Message-----</FONT>
<BR><FONT SIZE=2>> From: Liran Sorani </FONT>
<BR><FONT SIZE=2>> Sent: Sunday, August 07, 2005 5:57 PM</FONT>
<BR><FONT SIZE=2>> To: 'halr@voltaire.com'</FONT>
<BR><FONT SIZE=2>> Cc: 'openib-general@openib.org'; Amit Krig</FONT>
<BR><FONT SIZE=2>> Subject: [PATCH ] osmtest general cleanups</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Hi , Hal.</FONT>
<BR><FONT SIZE=2>> The attached patch should be applied to osmtest repository.</FONT>
<BR><FONT SIZE=2>> It contain several cleanups (on most of the files) :</FONT>
</P>
<P><FONT SIZE=2>It is easier if there is a patch per idea rather than an amalgam.</FONT>
</P>
<P><FONT SIZE=2>> -Removal of inform info flow .</FONT>
<BR><FONT SIZE=2>> -Unique error messages</FONT>
</P>
<P><FONT SIZE=2>There are some non real error message numbers (neither hex nor decimal)</FONT>
<BR><FONT SIZE=2>in osmt_multicast.c. Also, osmtest.c and osmt_service.c still have</FONT>
<BR><FONT SIZE=2>duplicates.</FONT>
</P>
<P><FONT SIZE=2>> -Makefile.am update for compilation (required osm_helper object)</FONT>
</P>
<P><FONT SIZE=2>osm_helper is part of the libopensm since r2973 so this part of the</FONT>
<BR><FONT SIZE=2>patch was not applied. Please update your osm directory.</FONT>
</P>
<P><FONT SIZE=2>> -Remove vendor dependencies.</FONT>
</P>
<P><FONT SIZE=2>Remove some OSM_VENDOR_INTF_MTL vendor dependencies</FONT>
<BR><FONT SIZE=2>(There are still some in osmt_slvl_vl_arb.c).</FONT>
</P>
<P><FONT SIZE=2>> The inform info flow should be carefully ported since it requires</FONT>
<BR><FONT SIZE=2>> direct access to ib_umad (possibly ib_verbs too) .</FONT>
</P>
<P><FONT SIZE=2>umad would be a temporary measure. </FONT>
</P>
<P><FONT SIZE=2>Why would ib_uverbs direct access be needed ?</FONT>
</P>
<P><FONT SIZE=2>> I'll send another patch for it next week .</FONT>
</P>
<P><FONT SIZE=2>Thanks.</FONT>
</P>
<P><FONT SIZE=2>-- Hal</FONT>
</P>
</BODY>
</HTML>