<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=US-ASCII">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>RE: [PATCH] osm: add a main auto tools project for osm</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>Hi Hal,</FONT>
</P>
<P><FONT SIZE=2>Thanks applying the patch. </FONT>
<BR><FONT SIZE=2>I will chase down the hard coded -g -O2 .</FONT>
<BR><FONT SIZE=2>I'll update my patch mail template...</FONT>
</P>
<P><FONT SIZE=2>I was using autoconf 2.57 for a while. It has issues with tracking usage of the same source code for two executables each with its own set of -D flags. (like if you want to compile a test program with a "-D_ALOW_MAIN_ ") .</FONT></P>
<P><FONT SIZE=2>Anyway this is not a must for OpenSM. </FONT>
</P>
<P><FONT SIZE=2>Eitan Zahavi</FONT>
<BR><FONT SIZE=2>Design Technology Director</FONT>
<BR><FONT SIZE=2>Mellanox Technologies LTD</FONT>
<BR><FONT SIZE=2>Tel:+972-4-9097208</FONT>
<BR><FONT SIZE=2>Fax:+972-4-9593245</FONT>
<BR><FONT SIZE=2>P.O. Box 586 Yokneam 20692 ISRAEL</FONT>
</P>
<BR>
<P><FONT SIZE=2>> -----Original Message-----</FONT>
<BR><FONT SIZE=2>> From: Hal Rosenstock [<A HREF="mailto:halr@voltaire.com">mailto:halr@voltaire.com</A>]</FONT>
<BR><FONT SIZE=2>> Sent: Monday, August 15, 2005 6:55 PM</FONT>
<BR><FONT SIZE=2>> To: Eitan Zahavi</FONT>
<BR><FONT SIZE=2>> Cc: OPENIB GENERAL</FONT>
<BR><FONT SIZE=2>> Subject: Re: [PATCH] osm: add a main auto tools project for osm</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Hi Eitan,</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> On Mon, 2005-08-15 at 10:23, Eitan Zahavi wrote:</FONT>
<BR><FONT SIZE=2>> > I'm now using xemacs as my mail client. This is pure unix and</FONT>
<BR><FONT SIZE=2>> > tested to work.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> That's better.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > This patch includes:</FONT>
<BR><FONT SIZE=2>> > 1. Added a top level autotools project for OpenSM.</FONT>
<BR><FONT SIZE=2>> > So now you need autogen.sh && configure && make && make install just</FONT>
<BR><FONT SIZE=2>> > once for osm</FONT>
<BR><FONT SIZE=2>> > (previously needed 4: complib, libvendor, opensm, osmtest).</FONT>
<BR><FONT SIZE=2>> > 2. Cleanup the direct override of libdir, bindir. Support --prefix</FONT>
<BR><FONT SIZE=2>> > 3. Move osm lib, bin into default prefix (/usr/local)</FONT>
<BR><FONT SIZE=2>> > 4. Support debug build for OpenSM using --enable-debug</FONT>
<BR><FONT SIZE=2>> > This is important to allow for asserts during runtime and various</FONT>
<BR><FONT SIZE=2>> > other additional debug features.</FONT>
<BR><FONT SIZE=2>> > Since the generated compilb can not be used with the release version</FONT>
<BR><FONT SIZE=2>> > we also use a special header file that stores the type of build</FONT>
<BR><FONT SIZE=2>> > for applications that wish to link with it.</FONT>
<BR><FONT SIZE=2>> > 5. Cleanup stale use of AC_CHECK_LIB with no parameters</FONT>
<BR><FONT SIZE=2>> > 6. Resolved another bug: iba/ib_types.h not installed correctly</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Thanks. Applied with the following minor modifications:</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Min autoconf version is 2.57 rather than 2.59</FONT>
<BR><FONT SIZE=2>> Min automake version is 1.6.3 rather than 1.9.3</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Also, the builds now show:</FONT>
<BR><FONT SIZE=2>> -g -O2 -g -O2 (when not configured with --enable-debug)</FONT>
<BR><FONT SIZE=2>> and</FONT>
<BR><FONT SIZE=2>> -g -O0 -D_DEBUG_ -g -O2 (when configured with --enable-debug)</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Not sure which -O option gcc takes in that case. Can you remove this</FONT>
<BR><FONT SIZE=2>> duplication ?</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > Signed-off-by: Eitan Zahavi eitan@mellanox.co.il</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> The email address should have braces around it in the signed off line:</FONT>
<BR><FONT SIZE=2>> Signed-off-by: Eitan Zahavi <eitan@mellanox.co.il></FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> -- Hal</FONT>
</P>
</BODY>
</HTML>