<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>RE: osm-1.8.0-merge nit</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>Hi Hal,</FONT>
<BR><FONT SIZE=2>Thanks. Fixed in this file and some other files where the problem existed.</FONT>
<BR><FONT SIZE=2>Yael</FONT>
</P>
<P><FONT SIZE=2>-----Original Message-----</FONT>
<BR><FONT SIZE=2>From: Hal Rosenstock [<A HREF="mailto:halr@voltaire.com">mailto:halr@voltaire.com</A>]</FONT>
<BR><FONT SIZE=2>Sent: Tuesday, August 30, 2005 7:14 PM</FONT>
<BR><FONT SIZE=2>To: Yael Kalka</FONT>
<BR><FONT SIZE=2>Cc: openib-general@openib.org</FONT>
<BR><FONT SIZE=2>Subject: osm-1.8.0-merge nit</FONT>
</P>
<BR>
<P><FONT SIZE=2>Hi Yael,</FONT>
</P>
<P><FONT SIZE=2>I'm starting to look at the complib changes with the 1.8.0 merge. One</FONT>
<BR><FONT SIZE=2>trivial thing is the following in include/complib/cl_event_wheel.h:</FONT>
</P>
<P><FONT SIZE=2>#ifdef __cplusplus</FONT>
<BR><FONT SIZE=2># define BEGIN_C_DECLS extern "C" {</FONT>
<BR><FONT SIZE=2># define END_C_DECLS }</FONT>
<BR><FONT SIZE=2>#else /* !__cplusplus */</FONT>
<BR><FONT SIZE=2># define BEGIN_C_DECLS</FONT>
<BR><FONT SIZE=2># define END_C_DECLS</FONT>
<BR><FONT SIZE=2>#endif /* __cplusplus */</FONT>
</P>
<P><FONT SIZE=2>BEGIN_C_DECLS</FONT>
</P>
<P><FONT SIZE=2>#include <complib/cl_atomic.h></FONT>
<BR><FONT SIZE=2>#include <complib/cl_qlist.h></FONT>
<BR><FONT SIZE=2>#include <complib/cl_qmap.h></FONT>
<BR><FONT SIZE=2>#include <complib/cl_timer.h></FONT>
<BR><FONT SIZE=2>#include <complib/cl_spinlock.h></FONT>
<BR><FONT SIZE=2>#include <opensm/osm_log.h></FONT>
</P>
<P><FONT SIZE=2>#ifdef __cplusplus</FONT>
<BR><FONT SIZE=2># define BEGIN_C_DECLS extern "C" {</FONT>
<BR><FONT SIZE=2># define END_C_DECLS }</FONT>
<BR><FONT SIZE=2>#else /* !__cplusplus */</FONT>
<BR><FONT SIZE=2># define BEGIN_C_DECLS</FONT>
</P>
<P><FONT SIZE=2>BEGIN_C_DECLS</FONT>
</P>
<P><FONT SIZE=2>The second occurence of this should be removed.</FONT>
</P>
<P><FONT SIZE=2>-- Hal</FONT>
</P>
</BODY>
</HTML>