<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>Re: [PATCHv2] OpenSM: OpenIB vendor layer: Implement osm_vendor_delete</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>> Hal Rosenstock wrote:</FONT>
<BR><FONT SIZE=2>> > On Tue, 2005-09-06 at 11:04, Eitan Zahavi wrote:</FONT>
<BR><FONT SIZE=2>> > </FONT>
<BR><FONT SIZE=2>> >Hal Rosenstock wrote:</FONT>
<BR><FONT SIZE=2>> ></FONT>
<BR><FONT SIZE=2>> >>[same patch just generated with diff -up]</FONT>
<BR><FONT SIZE=2>> >></FONT>
<BR><FONT SIZE=2>> >>OpenSM: OpenIB vendor layer: Implement osm_vendor_delete</FONT>
<BR><FONT SIZE=2>> >></FONT>
<BR><FONT SIZE=2>> >>[I've done some testing of this; are there any regressions for this ?]</FONT>
<BR><FONT SIZE=2>> >></FONT>
<BR><FONT SIZE=2>> >>OpenSM call osm_vendor_delete during osm_opensm_destroy.</FONT>
<BR><FONT SIZE=2>> >>It is invoked during exit.</FONT>
<BR><FONT SIZE=2>> > </FONT>
<BR><FONT SIZE=2>> > </FONT>
<BR><FONT SIZE=2>> > Actually, it should have said "Implement osm_vendor_unbind" rather than</FONT>
<BR><FONT SIZE=2>> > delete.</FONT>
<BR><FONT SIZE=2>> Well the semantics are very old. We stick to the old osm_vendor_api.h. Maybe we should not have.</FONT>
<BR><FONT SIZE=2>> But now we have too much depending on this API that I urge you not to modify it if possible.</FONT>
<BR><FONT SIZE=2>> > </FONT>
<BR><FONT SIZE=2>> > OpenSM calls it in a similar place (as it stops the SA and SM MAD</FONT>
<BR><FONT SIZE=2>> > controllers). I went through this starting and stopping the OpenSM a</FONT>
<BR><FONT SIZE=2>> > number of times although did not do this "infinitely".</FONT>
<BR><FONT SIZE=2>> > </FONT>
<BR><FONT SIZE=2>> > I was asking about any other explicit regressions.</FONT>
<BR><FONT SIZE=2>> No we do not have tests for the osm_vendor_api.h. It might have been a good idea.</FONT>
<BR><FONT SIZE=2>> We do have now some stuff for the Windows code. Maybe we should try and make a test suite</FONT>
<BR><FONT SIZE=2>> from it. Liran - what do you think ?</FONT>
<BR><FONT SIZE=2>I think that the vendor api should be tested with several bad flows (under OpenSM / Osmtest we use only the good flow ) , althrough not tested , I'm guiding a verficator (Yoav) to write directly over umad api test that send / receive SMP / GSI packets .</FONT></P>
<P><FONT SIZE=2>Liran.</FONT>
<BR><FONT SIZE=2>> > </FONT>
<BR><FONT SIZE=2>> > -- Hal</FONT>
</P>
</BODY>
</HTML>