<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=US-ASCII">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>Opensm - osm_sa_path_record.c - variable declaration</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>Hi Hal,</FONT>
</P>
<P><FONT SIZE=2>I saw that in your code fixes of osm_sa_path_record.c you added some variable declaration</FONT>
<BR><FONT SIZE=2>in the middle of function (osm_pr_rcv_process - in the McastDest case).</FONT>
<BR><FONT SIZE=2>Windows compiler does not enable declaration not in the beginning of the function, so I would</FONT>
<BR><FONT SIZE=2>like to have it changed. </FONT>
<BR><FONT SIZE=2>We can either move the declaration to the beginning of the function, or add {} around the declaration.</FONT>
<BR><FONT SIZE=2>Do you have a preference?</FONT>
<BR><FONT SIZE=2>Yael</FONT>
</P>
<BR>
<P><FONT SIZE=2>-----Original Message-----</FONT>
<BR><FONT SIZE=2>From: Yael Kalka </FONT>
<BR><FONT SIZE=2>Sent: Tuesday, September 20, 2005 10:48 AM</FONT>
<BR><FONT SIZE=2>To: halr@voltaire.com</FONT>
<BR><FONT SIZE=2>Cc: openib-general@openib.org; Eitan Zahavi; Yael Kalka</FONT>
<BR><FONT SIZE=2>Subject: [PATCH] Opensm - ignore strict-aliasing warning</FONT>
</P>
<BR>
<P><FONT SIZE=2>Hi Hal,</FONT>
</P>
<P><FONT SIZE=2>Attached is a patch forcing the compiler not to do strict-aliasing optimization on the opensm code, due to strict-aliasing warnings in our code.</FONT></P>
<P><FONT SIZE=2>Thanks,</FONT>
<BR><FONT SIZE=2>Yael</FONT>
</P>
<P><FONT SIZE=2>Signed-off-by: Yael Kalka <yael@mellanox.co.il></FONT>
</P>
<P><FONT SIZE=2>Index: opensm/Makefile.am</FONT>
<BR><FONT SIZE=2>===================================================================</FONT>
<BR><FONT SIZE=2>--- opensm/Makefile.am (revision 3487)</FONT>
<BR><FONT SIZE=2>+++ opensm/Makefile.am (working copy)</FONT>
<BR><FONT SIZE=2>@@ -64,7 +64,7 @@ opensm_SOURCES = main.c osm_db_files.c o</FONT>
<BR><FONT SIZE=2> osm_ucast_mgr.c osm_ucast_updn.c \</FONT>
<BR><FONT SIZE=2> osm_vl15intf.c osm_vl_arb_rcv.c\</FONT>
<BR><FONT SIZE=2> osm_vl_arb_rcv_ctrl.c st.c</FONT>
<BR><FONT SIZE=2>-opensm_CFLAGS = -Wall $(OSMV_CFLAGS) -DVENDOR_RMPP_SUPPORT $(DBGFLAGS) -D_XOPEN_SOURCE=600 -D_BSD_SOURCE=1</FONT>
<BR><FONT SIZE=2>+opensm_CFLAGS = -Wall $(OSMV_CFLAGS) -fno-strict-aliasing -DVENDOR_RMPP_SUPPORT $(DBGFLAGS) -D_XOPEN_SOURCE=600 -D_BSD_SOURCE=1</FONT></P>
<P><FONT SIZE=2> opensm_CXXFLAGS = -Wall $(OSMV_CFLAGS) -DVENDOR_RMPP_SUPPORT $(DBGFLAGS) -D_XOPEN_SOURCE=600 -D_BSD_SOURCE=1</FONT>
<BR><FONT SIZE=2> </FONT>
<BR><FONT SIZE=2> # for linking with the simulator client library we have to use g++:</FONT>
</P>
</BODY>
</HTML>