<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=US-ASCII">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>RE: [PATCH] Opensm - enabling erase of log file flag</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>You are right. Thanks!</FONT>
<BR><FONT SIZE=2>Yael</FONT>
</P>
<P><FONT SIZE=2>-----Original Message-----</FONT>
<BR><FONT SIZE=2>From: Hal Rosenstock [<A HREF="mailto:halr@voltaire.com">mailto:halr@voltaire.com</A>]</FONT>
<BR><FONT SIZE=2>Sent: Tuesday, October 11, 2005 3:18 PM</FONT>
<BR><FONT SIZE=2>To: Yael Kalka</FONT>
<BR><FONT SIZE=2>Cc: openib-general@openib.org; Eitan Zahavi</FONT>
<BR><FONT SIZE=2>Subject: Re: [PATCH] Opensm - enabling erase of log file flag</FONT>
</P>
<BR>
<P><FONT SIZE=2>Hi Yael,</FONT>
</P>
<P><FONT SIZE=2>On Tue, 2005-10-11 at 08:24, Yael Kalka wrote:</FONT>
<BR><FONT SIZE=2>> Currently the osm log file is accumulative. I've added an option to</FONT>
<BR><FONT SIZE=2>> erase the log file before starting to write it.</FONT>
<BR><FONT SIZE=2>> By default, still, the log is still accumulative.</FONT>
<BR><FONT SIZE=2>> Attached is a patch for that.</FONT>
</P>
<P><FONT SIZE=2>One minor comment on this...</FONT>
</P>
<P><FONT SIZE=2>> Thanks,</FONT>
<BR><FONT SIZE=2>> Yael</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Signed-off-by: Yael Kalka <yael@mellanox.co.il></FONT>
</P>
<P><FONT SIZE=2>> Index: opensm/osm_subnet.c</FONT>
<BR><FONT SIZE=2>> ===================================================================</FONT>
<BR><FONT SIZE=2>> --- opensm/osm_subnet.c (revision 3704)</FONT>
<BR><FONT SIZE=2>> +++ opensm/osm_subnet.c (working copy)</FONT>
</P>
<P><FONT SIZE=2>> @@ -920,6 +925,7 @@ osm_subn_write_conf_file(</FONT>
<BR><FONT SIZE=2>> "force_log_flush %s\n\n"</FONT>
<BR><FONT SIZE=2>> "# Log file to be used\n"</FONT>
<BR><FONT SIZE=2>> "log_file %s\n\n" </FONT>
<BR><FONT SIZE=2>> + "accum_log_file %s\n\n"</FONT>
<BR><FONT SIZE=2>> "# The directory to hold the file OpenSM dumps\n"</FONT>
<BR><FONT SIZE=2>> "dump_files_dir %s\n\n"</FONT>
<BR><FONT SIZE=2>> "# If TRUE if OpenSM should disable multicast support\n"</FONT>
<BR><FONT SIZE=2>> @@ -929,6 +935,7 @@ osm_subn_write_conf_file(</FONT>
<BR><FONT SIZE=2>> p_opts->log_flags,</FONT>
<BR><FONT SIZE=2>> p_opts->force_log_flush ? "TRUE" : "FALSE",</FONT>
<BR><FONT SIZE=2>> p_opts->log_file,</FONT>
<BR><FONT SIZE=2>> + p_opts->accum_log_file,</FONT>
</P>
<P><FONT SIZE=2>Shouldn't this line be:</FONT>
<BR> <FONT SIZE=2>p_opts->accum_log_file ? "TRUE" : "FALSE",</FONT>
</P>
<P><FONT SIZE=2>-- Hal</FONT>
</P>
</BODY>
</HTML>