<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>RE: [PATCH] Opensm - handling immediate error in vendor_send new</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>Hi Hal,</FONT>
</P>
<P><FONT SIZE=2>Hal Rosenstock wrote:</FONT>
</P>
<P><FONT SIZE=2>> Hi Yael,</FONT>
<BR><FONT SIZE=2>></FONT>
<BR><FONT SIZE=2>> On Tue, 2005-10-11 at 04:28, Yael Kalka wrote:</FONT>
<BR><FONT SIZE=2>> > Attached is a new patch with several fixes for this issue.</FONT>
<BR><FONT SIZE=2>></FONT>
<BR><FONT SIZE=2>> Thanks. Applied.</FONT>
<BR><FONT SIZE=2>></FONT>
<BR><FONT SIZE=2>> There were still extra whitespace issues which I fixed by hand. Please</FONT>
<BR><FONT SIZE=2>> try to eliminate these so I don't have to do hand touch ups.</FONT>
<BR><FONT SIZE=2>></FONT>
<BR><FONT SIZE=2>I will. Sorry.</FONT>
</P>
<P><FONT SIZE=2>> > I decided to remove the checking for zero in the atomic_dec after all,</FONT>
<BR><FONT SIZE=2>> > since as I mentioned before - clearing it is not a fix, and we will</FONT>
<BR><FONT SIZE=2>> > see the value in other infos in the log file.</FONT>
<BR><FONT SIZE=2>></FONT>
<BR><FONT SIZE=2>> But there is danger is these counters wrap, right ?</FONT>
<BR><FONT SIZE=2>></FONT>
<BR><FONT SIZE=2>There is still some danger - as you noted - the counters can wrap.</FONT>
<BR><FONT SIZE=2>This will happen if there is some problem in the lower layer.</FONT>
<BR><FONT SIZE=2>For example - if we get the same mad twice, and we allocated it already</FONT>
<BR><FONT SIZE=2>for another request (after getting the first answer).</FONT>
<BR><FONT SIZE=2>It shouldn't happen if the lower layer is functioning correctly.</FONT>
</P>
<P><FONT SIZE=2>> Also, in looking further at the code, the same issue does not appear to</FONT>
<BR><FONT SIZE=2>> occur for QP1 handling, right ?</FONT>
<BR><FONT SIZE=2>></FONT>
<BR><FONT SIZE=2>No. There is no such issue in the QP1 handling.</FONT>
</P>
<P><FONT SIZE=2>> -- Hal</FONT>
<BR><FONT SIZE=2>></FONT>
</P>
<BR>
</BODY>
</HTML>