<br><font size=2 face="sans-serif">The secret of 0036 was that we managed
to build a driver which didn't work in all cases.</font>
<br>
<br><font size=2 face="sans-serif">I would guess in these changes</font>
<br><font size=2><tt>> 33 files changed, 945 insertions(+), 1163
deletions(-)<br>
</tt></font>
<br><font size=2 face="sans-serif">There are about ~80 lines of new code,
rest of all that were modifications which don't change any algorithm but
are desperately needed to be kernel coding style compliant:</font>
<br><font size=2 face="sans-serif">That's the mostly complete list what
we've changed</font>
<br><font size=2 face="sans-serif">removing+renaming already existing assembly
macros in ehca_asm.h</font>
<br><font size=2 face="sans-serif">changed the ehca_module pointer to a
ehca_module struct</font>
<br><font size=2 face="sans-serif">removed EHCA_MEMPAGESIZE</font>
<br><font size=2 face="sans-serif">replaced quite a lot of typedef struct
by struct</font>
<br><font size=2 face="sans-serif">capitalize DEFINES, changed most struct
members to small letters</font>
<br><font size=2 face="sans-serif">replaced all ehca_retcode_t by u64</font>
<br><font size=2 face="sans-serif">replaced the ehca_sleep() by appropriate
kernel function</font>
<br><font size=2 face="sans-serif">replaced the assert() by BUG_ON()</font>
<br><font size=2 face="sans-serif">replaced ntohd()</font>
<br><font size=2 face="sans-serif">some naming and comment cleanup on struct
hcp_modify_qp_control_block</font>
<br>
<br><font size=2 face="sans-serif">Roland, in case you're missing some
some changes in there, we'll add these to one of the next releases to seperate
the</font>
<br><font size=2 face="sans-serif">coding style cleanups from the functional
changes.</font>
<br>
<br>
<br><font size=2 face="sans-serif">Gruss / Regards . . . Christoph R.</font>
<br>
<br>
<br><font size=2><tt>Roland Dreier <> wrote on 03.11.2005 20:13:58:<br>
<br>
> Heiko> this bug should be fixed in OpenIB trunk 3960.<br>
> <br>
> It's good to see this fixed and all the other cleanups in this<br>
> checkin. I'll have to go back to my ehca code reviewing....<br>
> <br>
> However, when this code moves upstream, you'll have to make your<br>
> changes in smaller digestible chunks. The diff between r3959
and<br>
> r3960 is rather gigantic:<br>
> <br>
> 33 files changed, 945 insertions(+), 1163 deletions(-)<br>
> <br>
> And this piece:<br>
> <br>
> > -MODULE_VERSION("EHCA2_0035");<br>
> > +MODULE_VERSION("EHCA2_0037");<br>
> <br>
> indicates that there was a 0036 that you never let anyone see.<br>
> <br>
> I would suggest you try to use the openib.org svn tree as your real<br>
> development repository. This will be the way you will have to
work<br>
> once your driver is in the upstream kernel, and even now you will
get<br>
> benefit from getting better patch review and having users better able<br>
> to pin down when a regression might have been introduced.<br>
> <br>
> For your latest checkin, it would have been better to see a series
of<br>
> changesets with commit logs like:<br>
> <br>
> - remove asm_sync_mem() and mftb(), which duplicate
existing<br>
> definitions in include/asm-ppc64<br>
> - make sure device is an eHCA in libehca's openib_driver_init()<br>
> - update Kconfig help text<br>
> <br>
> and so on...<br>
> <br>
> Thanks,<br>
> Roland<br>
</tt></font>