<html><body>
<p>Hello Roland,<br>
<br>
Sorry to bother you again. Could you please review below patch to see it's possible to be in upper stream soon? IPoIB can't ping each other if broadcast join successfully but encounting any other IB multicast join failure (like IB multicast group join failure for default IPv6 link local solicited address) when bringing the interface up. It does impact IPoIB usability in large node cluster when MCG LIDs are limited.<br>
<br>
Thanks<br>
Shirley Ma<br>
<br>
<br>
<font size="2" color="#800080">----- Forwarded by Shirley Ma/Beaverton/IBM</font><font size="2" color="#800080"> on 02/27/07 06:23 AM</font><font size="2" color="#800080"> -----</font><br>
<br>
<table width="100%" border="0" cellspacing="0" cellpadding="0">
<tr valign="top"><td style="background-image:url(cid:2__=08BBF81CDFE97D2F8f9e8a93df938@us.ibm.com); background-repeat: no-repeat; " width="40%">
<ul>
<ul>
<ul>
<ul><b><font size="2">Shirley Ma/Beaverton/IBM@IBMUS</font></b><font size="2"> </font><br>
<font size="2">Sent by: openib-general-bounces@openib.org</font>
<p><font size="2">02/05/07 06:50 AM</font></ul>
</ul>
</ul>
</ul>
</td><td width="60%">
<table width="100%" border="0" cellspacing="0" cellpadding="0">
<tr valign="top"><td width="1%"><img width="58" height="1" src="cid:3__=08BBF81CDFE97D2F8f9e8a93df938@us.ibm.com" border="0" alt=""><br>
<div align="right"><font size="2">To</font></div></td><td width="100%"><img width="1" height="1" src="cid:3__=08BBF81CDFE97D2F8f9e8a93df938@us.ibm.com" border="0" alt=""><br>
<font size="2">"Roland Dreier" <rdreier@cisco.com></font></td></tr>
<tr valign="top"><td width="1%"><img width="58" height="1" src="cid:3__=08BBF81CDFE97D2F8f9e8a93df938@us.ibm.com" border="0" alt=""><br>
<div align="right"><font size="2">cc</font></div></td><td width="100%"><img width="1" height="1" src="cid:3__=08BBF81CDFE97D2F8f9e8a93df938@us.ibm.com" border="0" alt=""><br>
<font size="2">openib-general@openib.org</font></td></tr>
<tr valign="top"><td width="1%"><img width="58" height="1" src="cid:3__=08BBF81CDFE97D2F8f9e8a93df938@us.ibm.com" border="0" alt=""><br>
<div align="right"><font size="2">Subject</font></div></td><td width="100%"><img width="1" height="1" src="cid:3__=08BBF81CDFE97D2F8f9e8a93df938@us.ibm.com" border="0" alt=""><br>
<font size="2">[openib-general] [PATCH] enable IPoIB only if broadcast join finish</font></td></tr>
</table>
<table border="0" cellspacing="0" cellpadding="0">
<tr valign="top"><td width="58"><img width="1" height="1" src="cid:3__=08BBF81CDFE97D2F8f9e8a93df938@us.ibm.com" border="0" alt=""></td><td width="336"><img width="1" height="1" src="cid:3__=08BBF81CDFE97D2F8f9e8a93df938@us.ibm.com" border="0" alt=""></td></tr>
</table>
</td></tr>
</table>
<br>
<font size="4">Hi, Roland,<br>
<br>
Please review this patch. According to IPoIB RFC4391 section 5, once IPoIB broacast group has been joined, the interface should be ready for data transfer. In current IPoIB implementation, the interface is UP and RUNNING when all default multicast join successful. We hit a problem while the broadcast join finishe and sucessful but the all hosts multicast join failure.<br>
<br>
Here is the patch, if possible please give your input asap, we have an urgent customer issue need to be resolved:<br>
<br>
diff -urpN ipoib/ipoib_multicast.c ipoib-multicast/ipoib_multicast.c<br>
--- ipoib/ipoib_multicast.c 2006-11-29 13:57:37.000000000 -0800<br>
+++ ipoib-multicast/ipoib_multicast.c 2007-02-04 22:34:16.000000000 -0800<br>
@@ -402,6 +402,11 @@ static void ipoib_mcast_join_complete(in<br>
queue_work(ipoib_workqueue, &priv->mcast_task);<br>
mutex_unlock(&mcast_mutex);<br>
complete(&mcast->done);<br>
+ /*<br>
+ * broadcast join finished, enable carrier<br>
+ */<br>
+ if (mcast == priv->broadcast)<br>
+ netif_carrier_on(dev);<br>
return;<br>
}<br>
<br>
@@ -599,7 +604,6 @@ void ipoib_mcast_join_task(void *dev_ptr<br>
ipoib_dbg_mcast(priv, "successfully joined all multicast groups\n");<br>
<br>
clear_bit(IPOIB_MCAST_RUN, &priv->flags);<br>
- netif_carrier_on(dev);<br>
}<br>
<br>
int ipoib_mcast_start_thread(struct net_device *dev)</font><font size="5"><br>
</font><i><font size="4"><br>
(See attached file: ipoib-multicast.patch)</font></i><font size="4"><br>
<br>
Thanks<br>
Shirley Ma<br>
IBM Linux Technology Center<br>
15300 SW Koll Parkway<br>
Beaverton, OR 97006-6063<br>
Phone(Fax): (503) 578-7638</font><i>(See attached file: ipoib-multicast.patch)</i><tt>_______________________________________________<br>
openib-general mailing list<br>
openib-general@openib.org<br>
</tt><tt><a href="http://openib.org/mailman/listinfo/openib-general">http://openib.org/mailman/listinfo/openib-general</a></tt><tt><br>
<br>
To unsubscribe, please visit </tt><tt><a href="http://openib.org/mailman/listinfo/openib-general">http://openib.org/mailman/listinfo/openib-general</a></tt></body></html>