<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 11 (filtered medium)">
<!--[if !mso]>
<style>
v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style>
<![endif]-->
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:blue;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:Arial;
color:navy;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor=white lang=EN-US link=blue vlink=blue>
<div class=Section1>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'>(I don’t think this made it to the
mailng list, so re-posting.)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'>I don’t disagree with the concept
here, but can you explain the problem that you’re seeing? Is it
that the path is assumed to be routed based on the hop_limit (set in
ib_init_ah_from_path)? Are any changes needed for active side processing?<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'>Btw, I’d prefer something more like:<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'>if (cm_req_get_primary_subnet_local…
)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'> primary_path->hop_limit
= 1;<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'>else<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'> primary_path->hop_limit
= req_msg->primary_hop_limit;<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'>(or ‘? :’ equivalent), versus
setting hop_limit, then overriding it in the common case. And I’m fine
if we don’t keep the comment.<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'>- Sean<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'><o:p> </o:p></span></font></p>
<div style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt'>
<div>
<div class=MsoNormal align=center style='text-align:center'><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>
<hr size=2 width="100%" align=center tabindex=-1>
</span></font></div>
<p class=MsoNormal><b><font size=2 face=Tahoma><span style='font-size:10.0pt;
font-family:Tahoma;font-weight:bold'>From:</span></font></b><font size=2
face=Tahoma><span style='font-size:10.0pt;font-family:Tahoma'> Jim Hall
[mailto:jhalljr@systemfabricworks.com] <br>
<b><span style='font-weight:bold'>Sent:</span></b> Monday, September 17, 2007
7:38 AM<br>
<b><span style='font-weight:bold'>To:</span></b> general@openfabrics<br>
<b><span style='font-weight:bold'>Cc:</span></b> Hefty, Sean<br>
<b><span style='font-weight:bold'>Subject:</span></b> [PATCH] core/cm: improve
request message interpertation of subnet local fields</span></font><o:p></o:p></p>
</div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
<div>
<p class=MsoNormal><font size=2 face="Courier New"><span style='font-size:10.0pt;
font-family:"Courier New"'> When parsing a CMA connect request message,
if the subnet local is 1 </span></font><o:p></o:p></p>
</div>
<div>
<p class=MsoNormal><font size=2 face="Courier New"><span style='font-size:10.0pt;
font-family:"Courier New"'>(both nodes on same subnet), then explicitly set the
hop limit in the corresponding</span></font><o:p></o:p></p>
</div>
<div>
<p class=MsoNormal><font size=2 face="Courier New"><span style='font-size:10.0pt;
font-family:"Courier New"'>path record to 1. This avoids a Global/Local
mis-configuration problem with Solaris </span></font><o:p></o:p></p>
</div>
<div>
<p class=MsoNormal><font size=2 face="Courier New"><span style='font-size:10.0pt;
font-family:"Courier New"'>infinband CMA sessions. </span></font> <o:p></o:p></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'> <o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=2 face="Courier New"><span style='font-size:10.0pt;
font-family:"Courier New"'>Signed-off-by: Jim L Hall <</span></font><font
size=2><span style='font-size:10.0pt'><a
href="mailto:jhalljr@systemfabricworks.com"><font face="Courier New"><span
style='font-family:"Courier New"'>jhalljr@systemfabricworks.com</span></font></a></span></font><font
size=2 face="Courier New"><span style='font-size:10.0pt;font-family:"Courier New"'>><br>
---<br>
drivers/infiniband/core/cm.c | 16 ++++++++++++++++<br>
1 files changed, 16 insertions(+), 0 deletions(-)</span></font><o:p></o:p></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'> <o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=2 face="Courier New"><span style='font-size:10.0pt;
font-family:"Courier New"'>diff --git a/drivers/infiniband/core/cm.c
b/drivers/infiniband/core/cm.c<br>
index d446998..3d8740c 100644<br>
--- a/drivers/infiniband/core/cm.c<br>
+++ b/drivers/infiniband/core/cm.c<br>
@@ -1109,6 +1109,14 @@ static void cm_format_paths_from_req(struct cm_req_msg
*req_msg,<br>
cm_req_get_primary_local_ack_timeout(req_msg);<br>
primary_path->packet_life_time -=
(primary_path->packet_life_time > 0);</span></font><o:p></o:p></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'> <o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=2 face="Courier New"><span style='font-size:10.0pt;
font-family:"Courier New"'>+ if
(cm_req_get_primary_subnet_local(req_msg) == 1) {<br>
+<br>
+
/* At this point we know that both sides are on the same<br>
+
* subnet, any hop limits above 1 don't make much sense<br>
+
*/<br>
+
primary_path->hop_limit = 1;<br>
+ }<br>
+<br>
if (req_msg->alt_local_lid) {<br>
memset(alt_path, 0, sizeof *alt_path);<br>
alt_path->dgid = req_msg->alt_local_gid;<br>
@@ -1129,6 +1137,14 @@ static void cm_format_paths_from_req(struct cm_req_msg
*req_msg,<br>
alt_path->packet_life_time =<br>
cm_req_get_alt_local_ack_timeout(req_msg);<br>
alt_path->packet_life_time -= (alt_path->packet_life_time > 0);<br>
+<br>
+
if (cm_req_get_alt_subnet_local(req_msg) == 1) {<br>
+<br>
+
/* At this point we know that both sides are on the same<br>
+
* subnet, any hop limits above 1 don't make much sense<br>
+
*/<br>
+
alt_path->hop_limit = 1;<br>
+
}<br>
}<br>
}</span></font><o:p></o:p></p>
</div>
<div>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'><br>
</span></font> <o:p></o:p></p>
</div>
</div>
</div>
</body>
</html>