<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META NAME="Generator" CONTENT="MS Exchange Server version 6.5.7651.59">
<TITLE>RE: [PATCH 11/13] QLogic VNIC: Driver utility file - implements various utility macros</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->
<P><FONT SIZE=2>Stephen,<BR>
<BR>
Stephen Hemminger [<A HREF="mailto:shemminger@vyatta.com">mailto:shemminger@vyatta.com</A>] wrote:<BR>
<BR>
> Ramachandra K <ramachandra.kuchimanchi@qlogic.com> wrote:<BR>
<BR>
>> +#define is_power_of2(value) (((value) & ((value - 1))) == 0)<BR>
>> +#define ALIGN_DOWN(x, a) ((x)&(~((a)-1)))<BR>
<BR>
> In kernel.h already<BR>
<BR>
Will fix this. Thanks.<BR>
<BR>
>> +extern u32 vnic_debug;<BR>
<BR>
> Use msg level macros instead?<BR>
<BR>
I am sorry, I did not understand this comment.<BR>
<BR>
> +<BR>
> +#define SYS_INFO(fmt, arg...) \<BR>
> + PRINT_CONDITIONAL(KERN_INFO, \<BR>
> + "SYS", \<BR>
> + (vnic_debug & DEBUG_SYS_INFO), \<BR>
> + fmt, ##arg)<BR>
> +<BR>
> +#endif /* VNIC_UTIL_H_INCLUDED */<BR>
<BR>
<BR>
> Many of these are already in standard macros pr_info, pr_err etc.<BR>
<BR>
These macros are for providing a debug log level functionality through<BR>
the vnic_debug module parameter.<BR>
<BR>
Regards,<BR>
Ram</FONT>
</P>
</BODY>
</HTML>