<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META NAME="Generator" CONTENT="MS Exchange Server version 6.5.7651.59">
<TITLE>RE: [PATCH 08/13] QLogic VNIC: sysfs interface implementation for the driver</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->
<P><FONT SIZE=2>Stephen,<BR>
<BR>
Stephen Hemminger [<A HREF="mailto:shemminger@vyatta.com">mailto:shemminger@vyatta.com</A>] wrote:<BR>
<BR>
>> On Wed, 30 Apr 2008 22:49:55 +0530<BR>
>> Ramachandra K <ramachandra.kuchimanchi@qlogic.com> wrote:<BR>
<BR>
<snip><BR>
<BR>
>> +static match_table_t vnic_opt_tokens = {<BR>
>> + {VNIC_OPT_IOC_GUID, "ioc_guid=%s"},<BR>
>> + {VNIC_OPT_DGID, "dgid=%s"},<BR>
>> + {VNIC_OPT_PKEY, "pkey=%x"},<BR>
>> + {VNIC_OPT_NAME, "name=%s"},<BR>
>> + {VNIC_OPT_INSTANCE, "instance=%d"},<BR>
>> + {VNIC_OPT_RXCSUM, "rx_csum=%s"},<BR>
>> + {VNIC_OPT_TXCSUM, "tx_csum=%s"},<BR>
>> + {VNIC_OPT_HEARTBEAT, "heartbeat=%d"},<BR>
>> + {VNIC_OPT_IOC_STRING, "ioc_string=\"%s"},<BR>
>> + {VNIC_OPT_IB_MULTICAST, "ib_multicast=%s"},<BR>
>> + {VNIC_OPT_ERR, NULL}<BR>
>> +};<BR>
>><BR>
<BR>
> NO<BR>
> 1. Most of this shouldn't be done via sysfs (rx_csum, tx_csum, ...)<BR>
> 2. Sysfs is one value per file not name=value<BR>
<BR>
The VNIC driver needs multiple parameters (IOCGUID, DGID etc) from user space<BR>
to connect to the EVIC. For this the "name=value" mechanism is used for<BR>
a write-only sysfs file as an input method to the driver.<BR>
<BR>
The driver follows the one value per file sysfs rule when it returns any data<BR>
with each readable file returning only a single value.<BR>
<BR>
Regards,<BR>
Ram</FONT>
</P>
</BODY>
</HTML>