<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style>
<!--
@font-face
{font-family:Calibri}
@font-face
{font-family:Tahoma}
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif"}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline}
a:visited, span.MsoHyperlinkFollowed
{color:purple;
text-decoration:underline}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif"}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif"}
span.BalloonTextChar
{font-family:"Tahoma","sans-serif"}
p.msochpdefault, li.msochpdefault, div.msochpdefault
{margin-right:0in;
margin-left:0in;
font-size:10.0pt;
font-family:"Calibri","sans-serif"}
span.emailstyle18
{font-family:"Calibri","sans-serif";
color:windowtext;
font-weight:normal;
font-style:normal;
text-decoration:none;
text-decoration:none}
span.balloontextchar0
{font-family:"Tahoma","sans-serif"}
span.emailstyle21
{font-family:"Calibri","sans-serif";
color:#1F497D;
font-weight:normal;
font-style:normal;
text-decoration:none;
text-decoration:none}
span.EmailStyle24
{font-family:"Calibri","sans-serif";
color:#1F497D;
font-weight:normal;
font-style:normal;
text-decoration:none;
text-decoration:none}
.MsoChpDefault
{font-size:10.0pt;
font-family:"Calibri","sans-serif"}
@page WordSection1
{margin:1.0in 1.0in 1.0in 1.0in}
-->
</style><style type="text/css" id="owaParaStyle"></style>
</head>
<body lang="EN-US" link="blue" vlink="purple" style="" fpstyle="1" ocsi="0">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">The race condition issue of INTx can be easily re-produced and it has two problems:
<div>1. Masking/Unmasking logic: When NVMeIsrIntx gets called, it should not assign pAE->IntxMasked as FALSE. Instead, we should do something related to masking/unmasking only when we confirm the ownership, i.e., there is pending completions. When DPC is called,
after fetching valid completed entry, mask the interrupt and then mark pAE->IntMasked as TRUE. Before exiting DPC, check pAE->IntMasked, unmask it and set pAE->IntMasked as FALSE only when pAE->IntMasked is TRUE.</div>
<div>2. Interrupt ownership claiming: the driver always claims the interrupt, which may cause some device malfunction when sharing the interrupt.</div>
<div><br>
</div>
<div>The errors I found in nvme.h and nvmereg.h are also quite mismatching with NVMe specification 1.0b. For example, when using Set Features command to configure interrupt coalescing, the both fields of DW11, aggregation time and threshold, are swapped.</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Alex</div>
<div><br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div id="divRpF201053" style="direction: ltr; "><font face="Tahoma" size="2" color="#000000"><b>From:</b> Luse, Paul E [paul.e.luse@intel.com]<br>
<b>Sent:</b> Thursday, April 26, 2012 7:00 PM<br>
<b>To:</b> Chang, Alex; nvmewin@lists.openfabrics.org<br>
<b>Subject:</b> RE: binary for the pending release<br>
</font><br>
</div>
<div></div>
<div>
<div class="WordSection1">
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span style="font-size:10.0pt; color:#1F497D">Cool, do you believe we need to hold the release for these – if so can you explain the impact of not doing so?</span></font></p>
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span style="font-size:10.0pt; color:#1F497D"> </span></font></p>
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span style="font-size:10.0pt; color:#1F497D">Thx</span></font></p>
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span style="font-size:10.0pt; color:#1F497D">Paul</span></font></p>
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span style="font-size:10.0pt; color:#1F497D"> </span></font></p>
<div>
<div style="border:none; border-top:solid #B5C4DF 1.0pt; padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><font size="2" face="Tahoma"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; font-weight:bold">From:</span></font></b><font size="2" face="Tahoma"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif""> Chang,
Alex [mailto:Alex.Chang@idt.com] <br>
<b><span style="font-weight:bold">Sent:</span></b> Thursday, April 26, 2012 6:14 PM<br>
<b><span style="font-weight:bold">To:</span></b> Luse, Paul E; nvmewin@lists.openfabrics.org<br>
<b><span style="font-weight:bold">Subject:</span></b> RE: binary for the pending release</span></font></p>
</div>
</div>
<p class="MsoNormal"><font size="2" face="Calibri"><span style="font-size:11.0pt"> </span></font></p>
<div>
<p class="MsoNormal"><font size="2" color="black" face="Tahoma"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black">I see. I will prepare a new patch then.
</span></font></p>
<div>
<p class="MsoNormal"><font size="2" color="black" face="Tahoma"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black"> </span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" color="black" face="Tahoma"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black">Thanks,</span></font></p>
</div>
<div>
<p class="MsoNormal"><font size="2" color="black" face="Tahoma"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black">Alex</span></font></p>
<div>
<div class="MsoNormal" align="center" style="text-align:center"><font size="3" color="black" face="Times New Roman"><span style="font-size:12.0pt; font-family:"Times New Roman","serif"; color:black">
<hr size="3" width="100%" align="center">
</span></font></div>
<div id="divRpF246472">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><font size="2" color="black" face="Tahoma"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black; font-weight:bold">From:</span></font></b><font size="2" color="black" face="Tahoma"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black">
Luse, Paul E [paul.e.luse@intel.com]<br>
<b><span style="font-weight:bold">Sent:</span></b> Thursday, April 26, 2012 4:55 PM<br>
<b><span style="font-weight:bold">To:</span></b> Chang, Alex; <a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">
nvmewin@lists.openfabrics.org</a><br>
<b><span style="font-weight:bold">Subject:</span></b> RE: binary for the pending release</span></font><font size="3" color="black" face="Times New Roman"><span style="font-size:12.0pt; font-family:"Times New Roman","serif"; color:black"></span></font></p>
</div>
<div>
<div>
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span style="font-size:10.0pt; color:#1F497D">The patch has already been applied so go ahead and start a new one based on the latest, make the changes, test and send to the list for review.</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span style="font-size:10.0pt; color:#1F497D"> </span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span style="font-size:10.0pt; color:#1F497D">Thx</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span style="font-size:10.0pt; color:#1F497D">Paul</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="#1f497d" face="Calibri"><span style="font-size:10.0pt; color:#1F497D"> </span></font><font color="black"><span style="color:black"></span></font></p>
<div>
<div style="border:none; border-top:solid #B5C4DF 1.0pt; padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style=""><b><font size="2" color="black" face="Tahoma"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black; font-weight:bold">From:</span></font></b><font size="2" color="black" face="Tahoma"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black">
Chang, Alex <a href="mailto:[mailto:Alex.Chang@idt.com]" target="_blank">[mailto:Alex.Chang@idt.com]</a>
<br>
<b><span style="font-weight:bold">Sent:</span></b> Thursday, April 26, 2012 4:46 PM<br>
<b><span style="font-weight:bold">To:</span></b> Luse, Paul E; <a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">
nvmewin@lists.openfabrics.org</a><br>
<b><span style="font-weight:bold">Subject:</span></b> RE: binary for the pending release</span></font><font color="black"><span style="color:black"></span></font></p>
</div>
</div>
<p class="MsoNormal"><font size="2" color="black" face="Calibri"><span style="font-size:11.0pt; color:black"> </span></font></p>
<p class="MsoNormal"><font size="2" color="blue" face="Arial"><span style="font-size:10.0pt; font-family:"Arial","sans-serif"; color:blue">Hi Paul,</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="3" color="black" face="Times New Roman"><span style="font-size:12.0pt; font-family:"Times New Roman","serif"; color:black"> </span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="blue" face="Arial"><span style="font-size:10.0pt; font-family:"Arial","sans-serif"; color:blue">I had fixed a race condition issue when using INTx interrupt and several errors found in nvme.h and nvmereg.h. I wonder
if it's okay to add the changes to your patch. Please let me know.</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="3" color="black" face="Times New Roman"><span style="font-size:12.0pt; font-family:"Times New Roman","serif"; color:black"> </span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="blue" face="Arial"><span style="font-size:10.0pt; font-family:"Arial","sans-serif"; color:blue">Thanks,</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="blue" face="Arial"><span style="font-size:10.0pt; font-family:"Arial","sans-serif"; color:blue">Alex</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="3" color="black" face="Times New Roman"><span style="font-size:12.0pt; font-family:"Times New Roman","serif"; color:black"> </span></font><font color="black"><span style="color:black"></span></font></p>
<div class="MsoNormal" align="center" style="text-align:center"><font size="3" color="black" face="Times New Roman"><span style="font-size:12.0pt; font-family:"Times New Roman","serif"; color:black">
<hr size="3" width="100%" align="center">
</span></font></div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><font size="2" color="black" face="Tahoma"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black; font-weight:bold">From:</span></font></b><font size="2" color="black" face="Tahoma"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black">
<a href="mailto:nvmewin-bounces@lists.openfabrics.org" target="_blank">nvmewin-bounces@lists.openfabrics.org</a>
<a href="mailto:[mailto:nvmewin-bounces@lists.openfabrics.org]" target="_blank">[mailto:nvmewin-bounces@lists.openfabrics.org]</a>
<b><span style="font-weight:bold">On Behalf Of </span></b>Luse, Paul E<br>
<b><span style="font-weight:bold">Sent:</span></b> Wednesday, April 25, 2012 8:55 AM<br>
<b><span style="font-weight:bold">To:</span></b> <a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">
nvmewin@lists.openfabrics.org</a><br>
<b><span style="font-weight:bold">Subject:</span></b> [nvmewin] ***UNCHECKED*** binary for the pending release</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="black" face="Calibri"><span style="font-size:10.0pt; color:black">pw is intel123. A few quick notes:</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="black" face="Calibri"><span style="font-size:10.0pt; color:black"> </span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoListParagraph" style="text-indent:-.25in"><font size="2" color="black" face="Calibri"><span style="font-size:10.0pt; color:black">-</span></font><font size="1" color="black" face="Times New Roman"><span style="font-size:7.0pt; font-family:"Times New Roman","serif"; color:black">
</span></font><font size="2" color="black"><span style="font-size:10.0pt; color:black">Both x86/64 fre and chk builds are included here</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoListParagraph" style="text-indent:-.25in"><font size="2" color="black" face="Calibri"><span style="font-size:10.0pt; color:black">-</span></font><font size="1" color="black" face="Times New Roman"><span style="font-size:7.0pt; font-family:"Times New Roman","serif"; color:black">
</span></font><font size="2" color="black"><span style="font-size:10.0pt; color:black">Source patch for these will be applied shortly</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoListParagraph" style="text-indent:-.25in"><font size="2" color="black" face="Calibri"><span style="font-size:10.0pt; color:black">-</span></font><font size="1" color="black" face="Times New Roman"><span style="font-size:7.0pt; font-family:"Times New Roman","serif"; color:black">
</span></font><font size="2" color="black"><span style="font-size:10.0pt; color:black">3 addt’l changes since our review</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoListParagraph" style="margin-left:1.0in; text-indent:-.25in"><font size="2" color="black" face="Courier New"><span style="font-size:10.0pt; font-family:"Courier New"; color:black">o</span></font><font size="1" color="black" face="Times New Roman"><span style="font-size:7.0pt; font-family:"Times New Roman","serif"; color:black">
</span></font><font size="2" color="black"><span style="font-size:10.0pt; color:black">Our ID ctrl stuct was missing 2 fields, IEEE and MAC</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoListParagraph" style="margin-left:1.0in; text-indent:-.25in"><font size="2" color="black" face="Courier New"><span style="font-size:10.0pt; font-family:"Courier New"; color:black">o</span></font><font size="1" color="black" face="Times New Roman"><span style="font-size:7.0pt; font-family:"Times New Roman","serif"; color:black">
</span></font><font size="2" color="black"><span style="font-size:10.0pt; color:black">The struct for the COAL feature cmd had two fields in the wrong order</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoListParagraph" style="margin-left:1.0in; text-indent:-.25in"><font size="2" color="black" face="Courier New"><span style="font-size:10.0pt; font-family:"Courier New"; color:black">o</span></font><font size="1" color="black" face="Times New Roman"><span style="font-size:7.0pt; font-family:"Times New Roman","serif"; color:black">
</span></font><font size="2" color="black"><span style="font-size:10.0pt; color:black">There was a typo in the INF for the x86 catalog file addition</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoListParagraph" style="text-indent:-.25in"><font size="2" color="black" face="Calibri"><span style="font-size:10.0pt; color:black">-</span></font><font size="1" color="black" face="Times New Roman"><span style="font-size:7.0pt; font-family:"Times New Roman","serif"; color:black">
</span></font><font size="2" color="black"><span style="font-size:10.0pt; color:black">I’ve run tests on the 64 bit versions so far, will look at 32 bit soon.
</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoListParagraph" style="text-indent:-.25in"><font size="2" color="black" face="Calibri"><span style="font-size:10.0pt; color:black">-</span></font><font size="1" color="black" face="Times New Roman"><span style="font-size:7.0pt; font-family:"Times New Roman","serif"; color:black">
</span></font><font size="2" color="black"><span style="font-size:10.0pt; color:black">The attached are signed for the convenience of testing on the 64 bit. I actually don’t have an issue posting these with my signature, again, for convenience only. Any issues
with that from everyone?</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="black" face="Calibri"><span style="font-size:10.0pt; color:black"> </span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="black" face="Calibri"><span style="font-size:10.0pt; color:black">Also, we’ll be covering the attached 2 slides at the NVME meeting this week, please review real quick and send any feedback by EOD</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="black" face="Calibri"><span style="font-size:10.0pt; color:black"> </span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="black" face="Calibri"><span style="font-size:10.0pt; color:black">Thx</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="black" face="Calibri"><span style="font-size:10.0pt; color:black">Paul</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="black" face="Calibri"><span style="font-size:10.0pt; color:black"> </span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="black" face="Tahoma"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black">____________________________________</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="black" face="Tahoma"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black">Paul Luse<br>
Sr. Staff Engineer<br>
PCG Server Software Engineering <br>
Desk: 480.554.3688, Mobile: 480.334.4630</span></font><font color="black"><span style="color:black"></span></font></p>
<p class="MsoNormal"><font size="2" color="black" face="Calibri"><span style="font-size:11.0pt; color:black"> </span></font></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>