<div>Hi All,</div>
<div> </div>
<div>
<p style="MARGIN:0in 0in 10pt" class="MsoNormal"><font size="3" face="Calibri">I apologize on my comments related to StartIo as I was referring the old trunk base.</font></p>
<p style="MARGIN:0in 0in 10pt" class="MsoNormal"><font size="3" face="Calibri">-----------------------</font></p>
<p style="MARGIN:0in 0in 10pt" class="MsoNormal"><font size="3" face="Calibri"> case SRB_FUNCTION_POWER:<br> pPowerSrb = (PSCSI_POWER_REQUEST_BLOCK)Srb;<br> Srb->SrbStatus = SRB_STATUS_SUCCESS;<br>
status = NVMePowerControl(pAdapterExtension, pPowerSrb);<br> IO_StorPortNotification(RequestComplete, pAdapterExtension, Srb);</font></p>
<p style="MARGIN:0in 0in 10pt" class="MsoNormal"><font size="3" face="Calibri">---------------------------</font></p>
<p style="MARGIN:0in 0in 10pt" class="MsoNormal"><font size="3" face="Calibri">which was corrected in updated code base.</font></p>
<p style="MARGIN:0in 0in 10pt" class="MsoNormal">Regards,</p>
<p style="MARGIN:0in 0in 10pt" class="MsoNormal">Ravi Kumar</p>
<p style="MARGIN:0in 0in 10pt" class="MsoNormal"><font size="3" face="Calibri"></font> </p></div>
<div class="gmail_quote">On Thu, May 3, 2012 at 5:47 AM, <span dir="ltr"><<a href="mailto:nvmewin-request@lists.openfabrics.org" target="_blank">nvmewin-request@lists.openfabrics.org</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT:#ccc 1px solid;MARGIN:0px 0px 0px 0.8ex;PADDING-LEFT:1ex" class="gmail_quote">Send nvmewin mailing list submissions to<br> <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<br>To subscribe or unsubscribe via the World Wide Web, visit<br> <a href="http://lists.openfabrics.org/cgi-bin/mailman/listinfo/nvmewin" target="_blank">http://lists.openfabrics.org/cgi-bin/mailman/listinfo/nvmewin</a><br>
or, via email, send a message with subject or body 'help' to<br> <a href="mailto:nvmewin-request@lists.openfabrics.org">nvmewin-request@lists.openfabrics.org</a><br><br>You can reach the person managing the list at<br>
<a href="mailto:nvmewin-owner@lists.openfabrics.org">nvmewin-owner@lists.openfabrics.org</a><br><br>When replying, please edit your Subject line so it is more specific<br>than "Re: Contents of nvmewin digest..."<br>
<br><br>Today's Topics:<br><br> 1. Re: StartIo Function Return value for NVMePowerControl<br> (Robles, Raymond C)<br> 2. Re: patch status (Chang, Alex)<br><br><br>----------------------------------------------------------------------<br>
<br>Message: 1<br>Date: Wed, 2 May 2012 18:50:54 +0000<br>From: "Robles, Raymond C" <<a href="mailto:raymond.c.robles@intel.com">raymond.c.robles@intel.com</a>><br>To: "Chang, Alex" <<a href="mailto:Alex.Chang@idt.com">Alex.Chang@idt.com</a>>, Ravi Kumar<br>
<<a href="mailto:v25ravi@gmail.com">v25ravi@gmail.com</a>>, "Luse, Paul E" <<a href="mailto:paul.e.luse@intel.com">paul.e.luse@intel.com</a>><br>Cc: "<a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a>" <<a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a>><br>
Subject: Re: [nvmewin] StartIo Function Return value for<br> NVMePowerControl<br>Message-ID:<br> <<a href="mailto:49158E750348AA499168FD41D88983600C39E541@FMSMSX105.amr.corp.intel.com">49158E750348AA499168FD41D88983600C39E541@FMSMSX105.amr.corp.intel.com</a>><br>
<br>Content-Type: text/plain; charset="us-ascii"<br><br>I must admit that I didn't quite understand the original problem stated and I should have asked for clarification sooner. Ravi, can you please explain the problem that you see in the SRB_FUNCTION_POWER case by using line numbers from the source code so that we can track where the potential issue before submitting a code patch?<br>
<br>Are you inferring that the StartIo function will return FALSE even when the power request has been successfully completed? As Alex mentioned, the StartIo function will return TRUE in the case of handling a SRB_FUNCTION_POWER request. However, please note that we call StorPortNotification with the correct SrbStatus immediately after the call to NVMePowerControl. This will complete the command appropriately back to Storport (with the correct status). The StartIo will always return TRUE indicating the command was successfully started.<br>
<br>Thanks,<br>Ray<br><br>From: <a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a> [mailto:<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a>] On Behalf Of Chang, Alex<br>
Sent: Wednesday, May 02, 2012 9:23 AM<br>To: Ravi Kumar; Luse, Paul E<br>Cc: <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>Subject: Re: [nvmewin] StartIo Function Return value for NVMePowerControl<br>
<br>Hi Ravi,<br><br>For SRB_FUNCTION_POWER requests, NVMeStartIo always returns TRUE (Line 1205 in nvmestd.c) to indicate the request had been successfully initiated/processed. I am not sure why you mentioned it returns FALSE to Storport driver?<br>
<br>Thanks,<br>Alex<br><br>________________________________<br>From: <a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a><mailto:<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a>> [mailto:<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a>]<mailto:[mailto:<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a>]> On Behalf Of Ravi Kumar<br>
Sent: Tuesday, May 01, 2012 8:42 PM<br>To: Luse, Paul E<br>Cc: <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><mailto:<a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a>><br>
Subject: Re: [nvmewin] StartIo Function Return value for NVMePowerControl<br>Hi Paul,<br><br>I'll put the patch with proper fix in a day and update the same.<br><br>Regards,<br>Ravi Kumar<br>On Wed, May 2, 2012 at 1:14 AM, Luse, Paul E <<a href="mailto:paul.e.luse@intel.com">paul.e.luse@intel.com</a><mailto:<a href="mailto:paul.e.luse@intel.com">paul.e.luse@intel.com</a>>> wrote:<br>
Thanks for the note Ravi. Can you please either put a patch together with the fix or simply enter a bug at <a href="https://www.openfabrics.org/resources/developer-tools/nvme-windows-development.html" target="_blank">https://www.openfabrics.org/resources/developer-tools/nvme-windows-development.html</a>. Using the list to simply report something is a good way to make sure it gets lost :)<br>
<br>From: <a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a><mailto:<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a>> [mailto:<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a><mailto:<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a>>] On Behalf Of Ravi Kumar<br>
Sent: Sunday, April 29, 2012 10:32 PM<br>To: <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><mailto:<a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a>><br>
Subject: [nvmewin] StartIo Function Return value for NVMePowerControl<br><br>Hi,<br><br>As per observation on Windows the function NVMeStarIo(NVMeStd.c) for Power management, in case NVMePowerControl()<br>returns false it is still completed the request in NVMeStartIo and returns FALSE to StorPort driver. Whereas in case of StartIo returns FALSE StorPort driver treats IO has some issue and try to complete its own in AdapterControl call which create the BSOD to system (Multiple_IO_Request_Complete error).<br>
Don't we required to put the check in case failure of handle the power management system need not to be complete the Io as PortDriver makes it complete its own.<br><br><br>Regards,<br>Ravi Kumar<br><br><br><br>--<br>
Regards,<br>Ravi<br><br>-------------- next part --------------<br>An HTML attachment was scrubbed...<br>URL: <<a href="http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120502/5e133e45/attachment-0001.html" target="_blank">http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120502/5e133e45/attachment-0001.html</a>><br>
<br>------------------------------<br><br>Message: 2<br>Date: Thu, 3 May 2012 00:05:15 +0000<br>From: "Chang, Alex" <<a href="mailto:Alex.Chang@idt.com">Alex.Chang@idt.com</a>><br>To: "Luse, Paul E" <<a href="mailto:paul.e.luse@intel.com">paul.e.luse@intel.com</a>>,<br>
"<a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a>" <<a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a>><br>Subject: Re: [nvmewin] patch status<br>
Message-ID:<br> <<a href="mailto:548C5470AAD9DA4A85D259B663190D360105C2@corpmail1.na.ads.idt.com">548C5470AAD9DA4A85D259B663190D360105C2@corpmail1.na.ads.idt.com</a>><br>Content-Type: text/plain; charset="us-ascii"<br>
<br>Hi Paul,<br><br>The latest patch you added is working fine with me. Thanks a lot for the effort.<br><br>Thanks,<br>Alex<br><br>________________________________<br>From: Luse, Paul E [mailto:<a href="mailto:paul.e.luse@intel.com">paul.e.luse@intel.com</a>]<br>
Sent: Wednesday, May 02, 2012 9:46 AM<br>To: Chang, Alex; <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>Subject: RE: patch status<br><br>Cool, thanks. We already presented the slides at the last WG meeting so not real concerned about that, just want to get that patch applied and binaries released sooner than later<br>
<br>Thx<br>Paul<br><br>From: Chang, Alex [mailto:<a href="mailto:Alex.Chang@idt.com">Alex.Chang@idt.com</a>]<br>Sent: Wednesday, May 02, 2012 8:42 AM<br>To: Luse, Paul E; <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
Subject: RE: patch status<br><br>Hi Paul,<br><br>I have reviewed the slides and they are okay to me. Kwok might have some comments.<br>As for the current sources, I started testing it yesterday, will let you know after more testing today.<br>
<br>Thanks,<br>Alex<br><br>________________________________<br>From: <a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a><mailto:<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a>> [mailto:<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a>]<mailto:[mailto:<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a>]> On Behalf Of Luse, Paul E<br>
Sent: Wednesday, May 02, 2012 8:05 AM<br>To: <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><mailto:<a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a>><br>
Subject: [nvmewin] patch status<br><br>Has everyone reviewed the last test/tested the release candidate that I sent out a while back? IDT/LSI?<br><br>Thx<br>Paul<br><br>____________________________________<br>Paul Luse<br>
Sr. Staff Engineer<br>PCG Server Software Engineering<br>Desk: 480.554.3688, Mobile: 480.334.4630<br><br>-------------- next part --------------<br>An HTML attachment was scrubbed...<br>URL: <<a href="http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120503/02092092/attachment.html" target="_blank">http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120503/02092092/attachment.html</a>><br>
<br>------------------------------<br><br>_______________________________________________<br>nvmewin mailing list<br><a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br><a href="http://lists.openfabrics.org/cgi-bin/mailman/listinfo/nvmewin" target="_blank">http://lists.openfabrics.org/cgi-bin/mailman/listinfo/nvmewin</a><br>
<br><br>End of nvmewin Digest, Vol 5, Issue 4<br>*************************************<br></blockquote></div><br><br clear="all"><br>-- <br>
<div>Regards,</div>
<div>Ravi</div><br>