<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html xmlns="http://www.w3.org/TR/REC-html40" xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="GENERATOR" content="MSHTML 8.00.6001.19258">
<!--[if !mso]>
<STYLE>v\:* {
BEHAVIOR: url(#default#VML)
}
o\:* {
BEHAVIOR: url(#default#VML)
}
w\:* {
BEHAVIOR: url(#default#VML)
}
.shape {
BEHAVIOR: url(#default#VML)
}
</STYLE>
<![endif]--><style>@font-face {
font-family: Calibri;
}
@font-face {
font-family: Tahoma;
}
@page WordSection1 {size: 8.5in 11.0in; margin: 1.0in 1.0in 1.0in 1.0in; }
P.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
LI.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
DIV.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
A:link {
COLOR: blue; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.MsoHyperlink {
COLOR: blue; TEXT-DECORATION: underline; mso-style-priority: 99
}
A:visited {
COLOR: purple; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.MsoHyperlinkFollowed {
COLOR: purple; TEXT-DECORATION: underline; mso-style-priority: 99
}
P.MsoAcetate {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Tahoma","sans-serif"; FONT-SIZE: 8pt; mso-style-priority: 99; mso-style-link: "Balloon Text Char"
}
LI.MsoAcetate {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Tahoma","sans-serif"; FONT-SIZE: 8pt; mso-style-priority: 99; mso-style-link: "Balloon Text Char"
}
DIV.MsoAcetate {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Tahoma","sans-serif"; FONT-SIZE: 8pt; mso-style-priority: 99; mso-style-link: "Balloon Text Char"
}
SPAN.BalloonTextChar {
FONT-FAMILY: "Tahoma","sans-serif"; mso-style-priority: 99; mso-style-link: "Balloon Text"; mso-style-name: "Balloon Text Char"
}
P.Default {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Arial","sans-serif"; COLOR: black; FONT-SIZE: 12pt; mso-style-name: Default
}
LI.Default {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Arial","sans-serif"; COLOR: black; FONT-SIZE: 12pt; mso-style-name: Default
}
DIV.Default {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Arial","sans-serif"; COLOR: black; FONT-SIZE: 12pt; mso-style-name: Default
}
SPAN.EmailStyle20 {
FONT-STYLE: normal; FONT-FAMILY: "Calibri","sans-serif"; COLOR: windowtext; FONT-WEIGHT: normal; TEXT-DECORATION: none; mso-style-type: personal
}
SPAN.EmailStyle21 {
FONT-STYLE: normal; FONT-FAMILY: "Calibri","sans-serif"; COLOR: #1f497d; FONT-WEIGHT: normal; TEXT-DECORATION: none; mso-style-type: personal
}
SPAN.EmailStyle22 {
FONT-STYLE: normal; FONT-FAMILY: "Calibri","sans-serif"; COLOR: #1f497d; FONT-WEIGHT: normal; TEXT-DECORATION: none; mso-style-type: personal
}
SPAN.EmailStyle23 {
FONT-STYLE: normal; FONT-FAMILY: "Calibri","sans-serif"; COLOR: #1f497d; FONT-WEIGHT: normal; TEXT-DECORATION: none; mso-style-type: personal
}
SPAN.EmailStyle24 {
FONT-STYLE: normal; FONT-FAMILY: "Calibri","sans-serif"; COLOR: #1f497d; FONT-WEIGHT: normal; TEXT-DECORATION: none; mso-style-type: personal
}
SPAN.EmailStyle25 {
FONT-STYLE: normal; FONT-FAMILY: "Times New Roman","serif"; COLOR: #1f497d; FONT-WEIGHT: normal; mso-style-type: personal-reply
}
.MsoChpDefault {
FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 10pt; mso-style-type: export-only
}
DIV.WordSection1 {
page: WordSection1
}
</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div dir="ltr" align="left"><span class="012292318-15082012"><font color="#0000ff" size="2" face="Arial">Sure. I am still working on it.</font></span></div>
<div dir="ltr" align="left"><span class="012292318-15082012"><font color="#0000ff" size="2" face="Arial"></font></span> </div>
<div dir="ltr" align="left"><span class="012292318-15082012"><font color="#0000ff" size="2" face="Arial">Thanks,</font></span></div>
<div dir="ltr" align="left"><span class="012292318-15082012"><font color="#0000ff" size="2" face="Arial">Alex</font></span></div>
<br>
<div dir="ltr" lang="en-us" class="OutlookMessageHeader" align="left">
<hr tabindex="-1">
<font size="2" face="Tahoma"><b>From:</b> nvmewin-bounces@lists.openfabrics.org [mailto:nvmewin-bounces@lists.openfabrics.org]
<b>On Behalf Of </b>Robles, Raymond C<br>
<b>Sent:</b> Wednesday, August 15, 2012 11:09 AM<br>
<b>To:</b> nvmewin@lists.openfabrics.org<br>
<b>Subject:</b> Re: [nvmewin] patch review status<br>
</font><br>
</div>
<div></div>
<div class="WordSection1">
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; COLOR: #1f497d; FONT-SIZE: 10pt">Sounds good.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; COLOR: #1f497d; FONT-SIZE: 10pt">Alex, please wait for the push of Paul’s changes before you send out your patch review request so that you can rebase his changes.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; COLOR: #1f497d; FONT-SIZE: 10pt">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; COLOR: #1f497d; FONT-SIZE: 10pt">Ray<o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<div>
<div style="BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<p class="MsoNormal"><b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">From:</span></b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt"> nvmewin-bounces@lists.openfabrics.org [mailto:nvmewin-bounces@lists.openfabrics.org]
<b>On Behalf Of </b>Luse, Paul E<br>
<b>Sent:</b> Wednesday, August 15, 2012 10:50 AM<br>
<b>To:</b> Chang, Alex; nvmewin@lists.openfabrics.org<br>
<b>Subject:</b> Re: [nvmewin] patch review status<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt">So I heard from Rick and Alex I assume you’re OK with the 2 small changes below. I’ll go ahead and make the changes and do some regression and get this to Ray for pushing later this week.
Next up… Alex’s sets of changes<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt">Thanks Everyone<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt">Paul<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<div>
<div style="BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<p class="MsoNormal"><b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">From:</span></b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt"> Chang, Alex
<a href="mailto:[mailto:Alex.Chang@idt.com]">[mailto:Alex.Chang@idt.com]</a> <br>
<b>Sent:</b> Wednesday, August 15, 2012 10:47 AM<br>
<b>To:</b> Luse, Paul E; <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> RE: patch review status<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">Thanks, Paul.</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">Alex</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p> </o:p></span></p>
<div style="TEXT-ALIGN: center" class="MsoNormal" align="center"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt">
<hr align="center" size="3" width="100%">
</span></div>
<p style="MARGIN-BOTTOM: 12pt" class="MsoNormal"><b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">From:</span></b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt"> Luse, Paul E
<a href="mailto:[mailto:paul.e.luse@intel.com]">[mailto:paul.e.luse@intel.com]</a>
<br>
<b>Sent:</b> Wednesday, August 15, 2012 10:43 AM<br>
<b>To:</b> Chang, Alex; <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> RE: patch review status</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt">OK, I think I can get behind that. I was thinking STS might not be valid when EN is 0 but looking at the spec I think this is fine<o:p></o:p></span></p>
<p class="Default"><b><span style="FONT-SIZE: 9pt">Ready (RDY): </span></b><span style="FONT-SIZE: 9pt">This field is set to ‘1’ when the controller is ready to process commands after CC.EN is set to ‘1’. This field shall be cleared to ‘0’ when CC.EN is cleared
to ‘0’. Commands shall not be issued to the controller until this field is set to ‘1’ after the CC.EN bit is set to ‘1’. Failure to follow this requirement produces undefined results. Host software shall wait a minimum of CAP.TO seconds for this field to be
set to ‘1’ after setting CC.EN to ‘1’ from a previous value of ‘0’. <o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt">So I’ll just chance the check below for EN == 1 to RDY == 1 then<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt">Thanks!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt">Paul<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<div>
<div style="BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<p class="MsoNormal"><b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">From:</span></b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt"> Chang, Alex
<a href="mailto:[mailto:Alex.Chang@idt.com]">[mailto:Alex.Chang@idt.com]</a> <br>
<b>Sent:</b> Wednesday, August 15, 2012 10:21 AM<br>
<b>To:</b> Luse, Paul E; <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> RE: patch review status<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">Absolutely. Now, the tricky part is when CC.EN=1 and STS.RDY never becomes 1. I'd say simply check STS.RDY only. If it's 1, then reset the device, otherwise,
skip resetting it. What do you think?</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">Thanks,</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">Alex</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p> </o:p></span></p>
<div style="TEXT-ALIGN: center" class="MsoNormal" align="center"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt">
<hr align="center" size="3" width="100%">
</span></div>
<p style="MARGIN-BOTTOM: 12pt" class="MsoNormal"><b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">From:</span></b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt"> Luse, Paul E
<a href="mailto:[mailto:paul.e.luse@intel.com]">[mailto:paul.e.luse@intel.com]</a>
<br>
<b>Sent:</b> Wednesday, August 15, 2012 9:56 AM<br>
<b>To:</b> Chang, Alex; <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> RE: patch review status</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt">OK, I see what you’re saying I think. We don’t want to check for RDY without first looking at EN so does this make sense:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> if (CC.EN == 1) {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt">
<span style="BACKGROUND: yellow; mso-highlight: yellow">-- now wait for RDY -</span><o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> /* Now reset */<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> CC.EN = 0;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> StorPortWriteRegisterUlong(pAE,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> (PULONG)(&pAE->pCtrlRegister->CC),<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> CC.AsUlong);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> }<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<div>
<div style="BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<p class="MsoNormal"><b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">From:</span></b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt"> Chang, Alex
<a href="mailto:[mailto:Alex.Chang@idt.com]">[mailto:Alex.Chang@idt.com]</a> <br>
<b>Sent:</b> Wednesday, August 15, 2012 9:52 AM<br>
<b>To:</b> Luse, Paul E; <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> RE: patch review status<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">Hi Paul,</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">I agree with the new logic on #3. However, instead of checking CC.EN, should we check STS.RDY or both?</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">Thanks,<br>
Alex</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p> </o:p></span></p>
<div style="TEXT-ALIGN: center" class="MsoNormal" align="center"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt">
<hr align="center" size="3" width="100%">
</span></div>
<p style="MARGIN-BOTTOM: 12pt" class="MsoNormal"><b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">From:</span></b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt"> Luse, Paul E
<a href="mailto:[mailto:paul.e.luse@intel.com]">[mailto:paul.e.luse@intel.com]</a>
<br>
<b>Sent:</b> Wednesday, August 15, 2012 9:03 AM<br>
<b>To:</b> Chang, Alex; <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> RE: patch review status</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #984807; FONT-SIZE: 10pt">Thanks Alex, see below.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<div>
<div style="BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<p class="MsoNormal"><b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">From:</span></b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt"> Chang, Alex
<a href="mailto:[mailto:Alex.Chang@idt.com]">[mailto:Alex.Chang@idt.com]</a> <br>
<b>Sent:</b> Wednesday, August 15, 2012 8:51 AM<br>
<b>To:</b> Luse, Paul E; <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> RE: patch review status<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">Hi Paul,</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">Some questions after browsing the difference between current source and your changes:</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">1. Why you removed "CC.SHN = 1;" in NVMeNormalShutdown routine?</span><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 10pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #984807; FONT-SIZE: 10pt">PL> Good eye, that was a mistake. I’ll add it back before pushing<o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; COLOR: #1f497d; FONT-SIZE: 12pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">2. In nvme.h, why you changed the opcode of NVM_DATASET_MANAGEMENT from 0x06 to 0x09?</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #984807; FONT-SIZE: 10pt">PL> 6 was wrong, 9 is correct per spec</span><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: #1f497d; FONT-SIZE: 10pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">3. Is there any specific reason(s), you added the following in NVMeInitialize, and then immediately clear EN without checking RDY = 1?</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt"> /* Set EN to 1 (all others zero) */<br>
CC.EN = 1;<br>
StorPortWriteRegisterUlong(pAE,<br>
(PULONG)(&pAE->pCtrlRegister->CC),<br>
CC.AsUlong);</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #984807; FONT-SIZE: 10pt">PL> I wrote this up in the patch submission and I can’t find that email right now. I didn’t add code, I changed code. Before, we use to set EN to 1, read it back, and then set it to 0 to
kick off a reset and then later we wait for RDY in the init state machine. We had an IHV complain that their implementation required waiting on RDY after setting EN 1 to even before clearing EN. So, our old implementation was a problem. So what I did now
is to not force a reset unless EN is set to 1 when we come in. If its set to 0 then either (a) we’re coming from power on or (b) the pre_OS reset the card when it was done. Either way if its already 0 then we’re in a known state so we do nothing and then
later we set to 1 and wait on RDY. If its 1 when we enter here we set to 0 and then later set to 1 and wait on RDY. Make sense? This assures we never enable without waiting for RDY<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt">***** WAS *******<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> /* Set EN to 1 (all others zero) */<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> CC.EN = 1;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> StorPortWriteRegisterUlong(pAE,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> (PULONG)(&pAE->pCtrlRegister->CC),<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> CC.AsUlong);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> /* Read it back */<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> CC.AsUlong =<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> StorPortReadRegisterUlong(pAE, (PULONG)(&pAE->pCtrlRegister->CC));<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> /* Now reset */<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> CC.EN = 0;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> StorPortWriteRegisterUlong(pAE,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> (PULONG)(&pAE->pCtrlRegister->CC),<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> CC.AsUlong);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> CC.AsUlong =<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> StorPortReadRegisterUlong(pAE, (PULONG)(&pAE->pCtrlRegister->CC));<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt">*** NOW IS *******<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> if (CC.EN == 1) {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> /* Now reset */<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> CC.EN = 0;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> StorPortWriteRegisterUlong(pAE,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> (PULONG)(&pAE->pCtrlRegister->CC),<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> CC.AsUlong);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"> }<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d; FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">Thanks,</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">Alex<o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p> </o:p></span></p>
<div style="TEXT-ALIGN: center" class="MsoNormal" align="center"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt">
<hr align="center" size="3" width="100%">
</span></div>
<p style="MARGIN-BOTTOM: 12pt" class="MsoNormal"><b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">From:</span></b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">
<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a>
<a href="mailto:[mailto:nvmewin-bounces@lists.openfabrics.org]">[mailto:nvmewin-bounces@lists.openfabrics.org]</a>
<b>On Behalf Of </b>Luse, Paul E<br>
<b>Sent:</b> Wednesday, August 15, 2012 8:12 AM<br>
<b>To:</b> <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> [nvmewin] patch review status</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-SIZE: 10pt">Just checking in… any questions to date and how are folks tracking for completing their review by this Fri?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="FONT-SIZE: 10pt">Thx<o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-SIZE: 10pt">Paul<o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-SIZE: 10pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">____________________________________</span><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">Paul Luse<br>
Sr. Staff Engineer<br>
PCG Server Software Engineering <br>
Desk: 480.554.3688, Mobile: 480.334.4630</span><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>