<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html xmlns="http://www.w3.org/TR/REC-html40" xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="GENERATOR" content="MSHTML 8.00.6001.19328">
<!--[if !mso]>
<STYLE>v\:* {
BEHAVIOR: url(#default#VML)
}
o\:* {
BEHAVIOR: url(#default#VML)
}
w\:* {
BEHAVIOR: url(#default#VML)
}
.shape {
BEHAVIOR: url(#default#VML)
}
</STYLE>
<![endif]--><style>@font-face {
font-family: Calibri;
}
@font-face {
font-family: Tahoma;
}
@page WordSection1 {size: 8.5in 11.0in; margin: 1.0in 1.0in 1.0in 1.0in; }
P.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
LI.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
DIV.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
A:link {
COLOR: blue; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.MsoHyperlink {
COLOR: blue; TEXT-DECORATION: underline; mso-style-priority: 99
}
A:visited {
COLOR: purple; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.MsoHyperlinkFollowed {
COLOR: purple; TEXT-DECORATION: underline; mso-style-priority: 99
}
P.MsoAcetate {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Tahoma","sans-serif"; FONT-SIZE: 8pt; mso-style-priority: 99; mso-style-link: "Balloon Text Char"
}
LI.MsoAcetate {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Tahoma","sans-serif"; FONT-SIZE: 8pt; mso-style-priority: 99; mso-style-link: "Balloon Text Char"
}
DIV.MsoAcetate {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Tahoma","sans-serif"; FONT-SIZE: 8pt; mso-style-priority: 99; mso-style-link: "Balloon Text Char"
}
P.MsoListParagraph {
MARGIN: 0in 0in 0pt 0.5in; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt; mso-style-priority: 34
}
LI.MsoListParagraph {
MARGIN: 0in 0in 0pt 0.5in; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt; mso-style-priority: 34
}
DIV.MsoListParagraph {
MARGIN: 0in 0in 0pt 0.5in; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt; mso-style-priority: 34
}
SPAN.EmailStyle18 {
FONT-FAMILY: "Calibri","sans-serif"; COLOR: windowtext; mso-style-type: personal
}
SPAN.EmailStyle19 {
FONT-FAMILY: "Calibri","sans-serif"; COLOR: #1f497d; mso-style-type: personal-reply
}
SPAN.BalloonTextChar {
FONT-FAMILY: "Tahoma","sans-serif"; mso-style-priority: 99; mso-style-link: "Balloon Text"; mso-style-name: "Balloon Text Char"
}
.MsoChpDefault {
FONT-SIZE: 10pt; mso-style-type: export-only
}
DIV.WordSection1 {
page: WordSection1
}
</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div dir="ltr" align="left"><span class="972123017-25102012"><font color="#0000ff" size="2" face="Arial">My concern is what if the allocation fails by any chance?</font></span></div>
<div dir="ltr" align="left"><span class="972123017-25102012"><font color="#0000ff" size="2" face="Arial"></font></span> </div>
<div dir="ltr" align="left"><span class="972123017-25102012"><font color="#0000ff" size="2" face="Arial">Alex</font></span></div>
<br>
<div dir="ltr" lang="en-us" class="OutlookMessageHeader" align="left">
<hr tabindex="-1">
<font size="2" face="Tahoma"><b>From:</b> Murray, Kris R [mailto:kris.r.murray@intel.com]
<br>
<b>Sent:</b> Thursday, October 25, 2012 10:23 AM<br>
<b>To:</b> Chang, Alex; nvmewin@lists.openfabrics.org<br>
<b>Subject:</b> RE: Bug Fix Patch - Review Request<br>
</font><br>
</div>
<div></div>
<div class="WordSection1">
<p class="MsoNormal"><span style="COLOR: #1f497d">Alex,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d">Since we don’t use the returned pointer I believe there is no need to validate it. The goal is to cause Storport to allocate a DMA adapter object. See the attached email from James Harris for more info.<br>
~Kris<o:p></o:p></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d"><o:p> </o:p></span></p>
<div>
<div style="BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<p class="MsoNormal"><b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">From:</span></b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt"> Chang, Alex [mailto:Alex.Chang@idt.com]
<br>
<b>Sent:</b> Thursday, October 25, 2012 10:11 AM<br>
<b>To:</b> Murray, Kris R; nvmewin@lists.openfabrics.org<br>
<b>Subject:</b> RE: Bug Fix Patch - Review Request<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">Hi Kris,</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">I have a quick question regarding StorPortGetUncachedExtension:</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">The routine returns a pointer to the allocated buffer, should we validate the pointer before proceeding?</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">Thanks,</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: blue; FONT-SIZE: 10pt">Alex</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p> </o:p></span></p>
<div style="TEXT-ALIGN: center" class="MsoNormal" align="center"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt">
<hr align="center" size="3" width="100%">
</span></div>
<p style="MARGIN-BOTTOM: 12pt" class="MsoNormal"><b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">From:</span></b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">
<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a>
<a href="mailto:[mailto:nvmewin-bounces@lists.openfabrics.org]">[mailto:nvmewin-bounces@lists.openfabrics.org]</a>
<b>On Behalf Of </b>Murray, Kris R<br>
<b>Sent:</b> Tuesday, October 16, 2012 10:07 AM<br>
<b>To:</b> <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> [nvmewin] Bug Fix Patch - Review Request</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><o:p></o:p></span></p>
<p class="MsoNormal">Hi all,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The attached NVMe.zip file changes include the below fixes:<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in" class="MsoListParagraph"><span style="FONT-FAMILY: Symbol">·</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>nvmeStd.c<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; MARGIN-LEFT: 1in" class="MsoListParagraph"><span style="FONT-FAMILY: 'Courier New'">o</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>Added a call to StorPortGetUncachedExtension to fix a checked OS assertion<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in" class="MsoListParagraph"><span style="FONT-FAMILY: Symbol">·</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>nvmeSnti.c<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; MARGIN-LEFT: 1in" class="MsoListParagraph"><span style="FONT-FAMILY: 'Courier New'">o</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>Fixed SntiTranslateRead6 function to use the Read mask for the lba instead of the write mask<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; MARGIN-LEFT: 1in" class="MsoListParagraph"><span style="FONT-FAMILY: 'Courier New'">o</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>Fixed SntiTranslateWrite6 function to use the correct macro for getting 24 bits from the CDB using the correct offset<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in" class="MsoListParagraph"><span style="FONT-FAMILY: Symbol">·</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>nvmeSntiTypes.h<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; MARGIN-LEFT: 1in" class="MsoListParagraph"><span style="FONT-FAMILY: 'Courier New'">o</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>Updated READ_6_CDB_LBA_MASK definition to match the one for write<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; MARGIN-LEFT: 1in" class="MsoListParagraph"><span style="FONT-FAMILY: 'Courier New'">o</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>Fixed WRITE_6_CDB_LBA_OFFSET from 0 to 1<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The attached Results.zip file contains results from the test matrix below:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Operating Systems:<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in" class="MsoListParagraph"><span style="FONT-FAMILY: Symbol">·</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>Windows 7<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in" class="MsoListParagraph"><span style="FONT-FAMILY: Symbol">·</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>Windows 8<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in" class="MsoListParagraph"><span style="FONT-FAMILY: Symbol">·</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>Windows Server 2008<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in" class="MsoListParagraph"><span style="FONT-FAMILY: Symbol">·</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>Windows Server 2012<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Tests:<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in" class="MsoListParagraph"><span style="FONT-FAMILY: Symbol">·</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>IOMeter<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in" class="MsoListParagraph"><span style="FONT-FAMILY: Symbol">·</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>SCSI Compliance<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in" class="MsoListParagraph"><span style="FONT-FAMILY: Symbol">·</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 7pt">
</span>PCMark<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review the changes, feeling free to send me comments and questions.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 10pt">~Kris Murray<o:p></o:p></span></p>
</div>
</body>
</html>