<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html xmlns="http://www.w3.org/TR/REC-html40" xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="GENERATOR" content="MSHTML 8.00.6001.19328">
<style>@font-face {
font-family: Wingdings;
}
@font-face {
font-family: Wingdings;
}
@font-face {
font-family: Calibri;
}
@page WordSection1 {size: 8.5in 11.0in; margin: 1.0in 1.0in 1.0in 1.0in; }
P.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
LI.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
DIV.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
A:link {
COLOR: blue; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.MsoHyperlink {
COLOR: blue; TEXT-DECORATION: underline; mso-style-priority: 99
}
A:visited {
COLOR: purple; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.MsoHyperlinkFollowed {
COLOR: purple; TEXT-DECORATION: underline; mso-style-priority: 99
}
P.MsoListParagraph {
MARGIN: 0in 0in 0pt 0.5in; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt; mso-style-priority: 34
}
LI.MsoListParagraph {
MARGIN: 0in 0in 0pt 0.5in; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt; mso-style-priority: 34
}
DIV.MsoListParagraph {
MARGIN: 0in 0in 0pt 0.5in; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt; mso-style-priority: 34
}
SPAN.EmailStyle17 {
FONT-FAMILY: "Calibri","sans-serif"; COLOR: windowtext; mso-style-type: personal-compose
}
.MsoChpDefault {
FONT-FAMILY: "Calibri","sans-serif"; mso-style-type: export-only
}
DIV.WordSection1 {
page: WordSection1
}
OL {
MARGIN-BOTTOM: 0in
}
UL {
MARGIN-BOTTOM: 0in
}
</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div dir="ltr" align="left"><span class="153160817-25102012"><font color="#0000ff" size="2" face="Arial">Hi Kris,</font></span></div>
<div dir="ltr" align="left"><span class="153160817-25102012"><font color="#0000ff" size="2" face="Arial"></font></span> </div>
<div dir="ltr" align="left"><span class="153160817-25102012"><font color="#0000ff" size="2" face="Arial">I have a quick question regarding StorPortGetUncachedExtension:</font></span></div>
<div dir="ltr" align="left"><span class="153160817-25102012"><font color="#0000ff" size="2" face="Arial">The routine returns a pointer to the allocated buffer, should we validate the pointer before proceeding?</font></span></div>
<div dir="ltr" align="left"><span class="153160817-25102012"><font color="#0000ff" size="2" face="Arial"></font></span> </div>
<div dir="ltr" align="left"><span class="153160817-25102012"><font color="#0000ff" size="2" face="Arial">Thanks,</font></span></div>
<div dir="ltr" align="left"><span class="153160817-25102012"><font color="#0000ff" size="2" face="Arial">Alex</font></span></div>
<br>
<div dir="ltr" lang="en-us" class="OutlookMessageHeader" align="left">
<hr tabindex="-1">
<font size="2" face="Tahoma"><b>From:</b> nvmewin-bounces@lists.openfabrics.org [mailto:nvmewin-bounces@lists.openfabrics.org]
<b>On Behalf Of </b>Murray, Kris R<br>
<b>Sent:</b> Tuesday, October 16, 2012 10:07 AM<br>
<b>To:</b> nvmewin@lists.openfabrics.org<br>
<b>Subject:</b> [nvmewin] Bug Fix Patch - Review Request<br>
</font><br>
</div>
<div></div>
<div class="WordSection1">
<p class="MsoNormal">Hi all,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The attached NVMe.zip file changes include the below fixes:<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; mso-list: l1 level1 lfo3" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: Symbol"><span style="mso-list: Ignore">·<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>nvmeStd.c<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; MARGIN-LEFT: 1in; mso-list: l1 level2 lfo3" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: 'Courier New'"><span style="mso-list: Ignore">o<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>Added a call to StorPortGetUncachedExtension to fix a checked OS assertion<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; mso-list: l1 level1 lfo3" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: Symbol"><span style="mso-list: Ignore">·<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>nvmeSnti.c<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; MARGIN-LEFT: 1in; mso-list: l1 level2 lfo3" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: 'Courier New'"><span style="mso-list: Ignore">o<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>Fixed SntiTranslateRead6 function to use the Read mask for the lba instead of the write mask<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; MARGIN-LEFT: 1in; mso-list: l1 level2 lfo3" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: 'Courier New'"><span style="mso-list: Ignore">o<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>Fixed SntiTranslateWrite6 function to use the correct macro for getting 24 bits from the CDB using the correct offset<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; mso-list: l1 level1 lfo3" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: Symbol"><span style="mso-list: Ignore">·<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>nvmeSntiTypes.h<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; MARGIN-LEFT: 1in; mso-list: l1 level2 lfo3" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: 'Courier New'"><span style="mso-list: Ignore">o<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>Updated READ_6_CDB_LBA_MASK definition to match the one for write<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; MARGIN-LEFT: 1in; mso-list: l1 level2 lfo3" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: 'Courier New'"><span style="mso-list: Ignore">o<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>Fixed WRITE_6_CDB_LBA_OFFSET from 0 to 1<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The attached Results.zip file contains results from the test matrix below:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Operating Systems:<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; mso-list: l2 level1 lfo1" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: Symbol"><span style="mso-list: Ignore">·<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>Windows 7<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; mso-list: l2 level1 lfo1" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: Symbol"><span style="mso-list: Ignore">·<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>Windows 8<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; mso-list: l2 level1 lfo1" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: Symbol"><span style="mso-list: Ignore">·<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>Windows Server 2008<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; mso-list: l2 level1 lfo1" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: Symbol"><span style="mso-list: Ignore">·<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>Windows Server 2012<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Tests:<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; mso-list: l0 level1 lfo2" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: Symbol"><span style="mso-list: Ignore">·<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>IOMeter<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; mso-list: l0 level1 lfo2" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: Symbol"><span style="mso-list: Ignore">·<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>SCSI Compliance<o:p></o:p></p>
<p style="TEXT-INDENT: -0.25in; mso-list: l0 level1 lfo2" class="MsoListParagraph">
<![if !supportLists]><span style="FONT-FAMILY: Symbol"><span style="mso-list: Ignore">·<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><![endif]>PCMark<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review the changes, feeling free to send me comments and questions.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 10pt">~Kris Murray<o:p></o:p></span></p>
</div>
</body>
</html>