<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style>@font-face {
font-family: SimSun;
}
@font-face {
font-family: SimSun;
}
@font-face {
font-family: Calibri;
}
@font-face {
font-family: Tahoma;
}
@font-face {
font-family: ;
}
@page WordSection1 {margin: 1.0in 1.0in 1.0in 1.0in; }
P.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
LI.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
DIV.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
A:link {
COLOR: blue; TEXT-DECORATION: underline
}
SPAN.MsoHyperlink {
COLOR: blue; TEXT-DECORATION: underline
}
A:visited {
COLOR: purple; TEXT-DECORATION: underline
}
SPAN.MsoHyperlinkFollowed {
COLOR: purple; TEXT-DECORATION: underline
}
P.MsoAcetate {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Tahoma","sans-serif"; FONT-SIZE: 8pt
}
LI.MsoAcetate {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Tahoma","sans-serif"; FONT-SIZE: 8pt
}
DIV.MsoAcetate {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Tahoma","sans-serif"; FONT-SIZE: 8pt
}
P.MsoListParagraph {
MARGIN: 0in 0in 0pt 0.5in; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
LI.MsoListParagraph {
MARGIN: 0in 0in 0pt 0.5in; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
DIV.MsoListParagraph {
MARGIN: 0in 0in 0pt 0.5in; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
SPAN.BalloonTextChar {
FONT-FAMILY: "Tahoma","sans-serif"
}
SPAN.EmailStyle20 {
FONT-STYLE: normal; FONT-FAMILY: "Times New Roman","serif"; COLOR: #1f497d; FONT-WEIGHT: normal
}
SPAN.EmailStyle21 {
FONT-STYLE: normal; FONT-FAMILY: "Times New Roman","serif"; COLOR: #1f497d; FONT-WEIGHT: normal
}
SPAN.EmailStyle22 {
FONT-FAMILY: "Calibri","sans-serif"; COLOR: #1f497d
}
SPAN.EmailStyle23 {
FONT-FAMILY: "Calibri","sans-serif"; COLOR: #1f497d
}
SPAN.EmailStyle24 {
FONT-FAMILY: "Calibri","sans-serif"; COLOR: #1f497d
}
SPAN.EmailStyle25 {
FONT-FAMILY: "Calibri","sans-serif"; COLOR: #1f497d
}
SPAN.EmailStyle26 {
FONT-FAMILY: "Calibri","sans-serif"; COLOR: #1f497d
}
.MsoChpDefault {
FONT-SIZE: 10pt
}
DIV.WordSection1 {
}
OL {
MARGIN-BOTTOM: 0in
}
UL {
MARGIN-BOTTOM: 0in
}
</style>
<meta name="GENERATOR" content="MSHTML 8.00.6001.19412">
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div dir="ltr" align="left"><span class="000531216-30042013"><font color="#0000ff" size="2" face="Arial">Hi Dharani,</font></span></div>
<div dir="ltr" align="left"><span class="000531216-30042013"><font color="#0000ff" size="2" face="Arial"></font></span> </div>
<div dir="ltr" align="left"><span class="000531216-30042013"><font color="#0000ff" size="2" face="Arial">I'd suggest that it's safer to initialize gModeSenseBuf as all zeros each time before it is used, just in case there are some unexpected data in the buffer.
Other than that, I am fine with the patch.</font></span></div>
<div dir="ltr" align="left"><span class="000531216-30042013"><font color="#0000ff" size="2" face="Arial"></font></span> </div>
<div dir="ltr" align="left"><span class="000531216-30042013"><font color="#0000ff" size="2" face="Arial">Thanks,</font></span></div>
<div dir="ltr" align="left"><span class="000531216-30042013"><font color="#0000ff" size="2" face="Arial">Alex</font></span></div>
<br>
<div dir="ltr" lang="en-us" class="OutlookMessageHeader" align="left">
<hr tabindex="-1">
<font size="2" face="Tahoma"><b>From:</b> nvmewin-bounces@lists.openfabrics.org [mailto:nvmewin-bounces@lists.openfabrics.org]
<b>On Behalf Of </b>Dharani Kotte<br>
<b>Sent:</b> Tuesday, April 30, 2013 8:37 AM<br>
<b>To:</b> nvmewin@lists.openfabrics.org<br>
<b>Subject:</b> [nvmewin] New Patch From Sandisk<br>
</font><br>
</div>
<div></div>
<div class="WordSection1">
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 10pt">Hi all,<br>
<br>
It's been almost two weeks after I sent out the patch. please let us know if you're okay with it.</span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 10pt"></span> </p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 10pt">Thanks,</span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 10pt">Dharani.<br>
<br>
</span><span style="FONT-FAMILY: 'Arial','sans-serif'; COLOR: #1f497d"></span></p>
<p class="MsoNormal"><span style="COLOR: #1f497d"></span> </p>
<div>
<div style="BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<p class="MsoNormal"><b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt">From:</span></b><span style="FONT-FAMILY: 'Tahoma','sans-serif'; FONT-SIZE: 10pt"> Dharani Kotte
<br>
<b>Sent:</b> Friday, April 12, 2013 9:58 AM<br>
<b>To:</b> nvmewin@lists.openfabrics.org<br>
<b>Subject:</b> New Patch From Sandisk</span></p>
</div>
</div>
<p class="MsoNormal"> </p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 12pt">Hi all,</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"></span></p>
<div>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"></span> </p>
</div>
<div>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 12pt">I am attaching a new patch that includes the following changes:</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"></span></p>
</div>
<div>
<p style="TEXT-INDENT: -0.25in" class="MsoListParagraph"><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 12pt"><span>1.<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><span dir="ltr"></span><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 12pt">In nvmeSnti.c</span></p>
<p style="TEXT-INDENT: -0.25in; MARGIN-LEFT: 1in" class="MsoListParagraph"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><span>a.<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><span dir="ltr"></span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt">Allocate a global buffer of 256bytes size for modesense return data preparation</span></p>
<p style="TEXT-INDENT: -0.25in; MARGIN-LEFT: 1in" class="MsoListParagraph"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><span>b.<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><span dir="ltr"></span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt">For any mode sense this buffer is used for modesense data along with the requested pages in it.</span></p>
<p style="TEXT-INDENT: -0.25in; MARGIN-LEFT: 1in" class="MsoListParagraph"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><span>c.<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><span dir="ltr"></span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt">Copy the required data according to the alloc_length requested in the cdb to the Srb->DataBuffer and update the dataTransferLength accordingly</span></p>
<p style="TEXT-INDENT: -0.25in; MARGIN-LEFT: 1in" class="MsoListParagraph"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"><span>d.<span style="FONT: 7pt 'Times New Roman'">
</span></span></span><span dir="ltr"></span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt">In function SntiTranslateReturnAllModePagesResponse() the modesense data header offset is calculated wrong which ends up in BSOD in some cases
modified code to fix this issue</span></p>
</div>
<div>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"></span> </p>
</div>
<div>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 12pt">Please review the changes and provide feedbacks if you have any. If nobody disagrees with the changes, I will remind Ray to merge them in two weeks.</span><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"></span></p>
</div>
<div>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"></span> </p>
</div>
<div>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 12pt">Thanks,</span></p>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Arial','sans-serif'; FONT-SIZE: 12pt">Dharani.</span></p>
</div>
<div>
<p class="MsoNormal"><span style="FONT-FAMILY: 'Times New Roman','serif'; FONT-SIZE: 12pt"></span> </p>
</div>
</div>
<br>
<hr>
<font color="gray" size="2" face="Arial"><br>
PLEASE NOTE: The information contained in this electronic mail message is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended recipient, you are hereby notified that you have received this
message in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify the sender by telephone or e-mail (as shown above) immediately and destroy
any and all copies of this message in your possession (whether hard copies or electronically stored copies).<br>
<br>
</font>
</body>
</html>