<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">This is a reminder of the procedure to submit patch:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Process: <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">- Submitter needs to base their changes on the latest (and re-base/re-test prior to sending their patch).
<o:p></o:p></p>
<p class="MsoNormal">- They send the patch to the email list "<a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a>".<o:p></o:p></p>
<p class="MsoNormal">- Some review will happen over the reflector, the maintainer will send a message out that the db is locked
<o:p></o:p></p>
<p class="MsoNormal"> when they’re ready to apply the patch which will be once at least one member from each company
<o:p></o:p></p>
<p class="MsoNormal"> on the review panel has approved (can be via email or con call if needed). Once the patch is applied,
<o:p></o:p></p>
<p class="MsoNormal"> the maintainer will send an email out.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Patch contents: <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">- Code changes, short summary for SVN log, more verbose write up for release notes, confirmation of what Windows platforms had been tested.<o:p></o:p></p>
<p class="MsoNormal">- Patch must follow the coding guidelines as attached.<o:p></o:p></p>
<p class="MsoNormal">- All source files should be zipped up into a .zip file with password enabled. The zip file name should properly describe the main changes of the patch<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Reviews:<o:p></o:p></p>
<p class="MsoNormal">- Patches submitted by anyone, email to distribution list "<a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a>".<o:p></o:p></p>
<p class="MsoNormal">- Patch submission should include time sensitivity/expectations<o:p></o:p></p>
<p class="MsoNormal">- Patch submission should include justification for the patch (what value will it add, and are
<o:p></o:p></p>
<p class="MsoNormal"> tradeoffs what are they and why would we want to take a hit). If multiple implementation
<o:p></o:p></p>
<p class="MsoNormal"> options were considered, what data/reasoning was behind the implementation choice.<o:p></o:p></p>
<p class="MsoNormal">- At a minimum reviews need to be completed by Intel, PMC and LSI representative<o:p></o:p></p>
<p class="MsoNormal">- Reviews include compliance with coding guidelines (in SVN) as well as logic<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Testing: <o:p></o:p></p>
<p class="MsoNormal">- All patches and release candidates required, at a minimum, the following;<o:p></o:p></p>
<p class="MsoNormal"> - 1 hour of data integrity testing using sdstress (Microsoft Tool)<o:p></o:p></p>
<p class="MsoNormal"> - 1 hour of heavy stress testing using IOMETER covering, at least, 512B, 4KB and 128KB ranging
<o:p></o:p></p>
<p class="MsoNormal"> from 1 OIO to 64 OIO both sequential and random<o:p></o:p></p>
<p class="MsoNormal"> - Quick and slow format of both MBR and GPT partitioning<o:p></o:p></p>
<p class="MsoNormal"> - Microsoft SCSI Compliance, no failures except (warnings OK)<o:p></o:p></p>
<p class="MsoNormal"> - Additional testing with other tools is encouraged<o:p></o:p></p>
<p class="MsoNormal"> - Occurs in all supported OSs for the release
<o:p></o:p></p>
<p class="MsoNormal"> - 64-bit, Windows 7, 8.0, 8,1, server 2008R2 and 2012<o:p></o:p></p>
<p class="MsoNormal"> - 32-bit, Windows 7, 8.0<o:p></o:p></p>
<p class="MsoNormal"> - Minimum test platform is latest QEMU. Those with their HW should test on it as well.
<o:p></o:p></p>
<p class="MsoNormal"> QEMU is available at <a href="https://github.com/nvmeqemu/nvmeqemu">
https://github.com/nvmeqemu/nvmeqemu</a> <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>