<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle24
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Thank you Parag.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">What version of the SCSI Compliance Test utility you use? What OS you were running the tests on?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Alex <o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Parag Sheth [mailto:parag.sheth@avagotech.com]
<br>
<b>Sent:</b> Monday, August 25, 2014 2:57 PM<br>
<b>To:</b> Alex Chang; nvmewin@lists.openfabrics.org<br>
<b>Subject:</b> RE: [nvmewin] PMC Patch For SCSI Compliance Fixes And Others<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Alex,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">I did review the changes and they seem ok except</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">A new error is introduced in SCSI Compliance Test. (Test 1.21 Checking Identification Descriptors in VPD page 0x83 fails). It complains that it did not find identifier of type 3, 2 and 1.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Parag Sheth</span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Alex Chang [mailto:<a href="mailto:Alex.Chang@pmcs.com">Alex.Chang@pmcs.com</a>]
<br>
<b>Sent:</b> Tuesday, August 19, 2014 4:10 PM<br>
<b>To:</b> Parag Sheth; <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> RE: [nvmewin] PMC Patch For SCSI Compliance Fixes And Others</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Parag,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">We had pushed a patch from Carolyn (Intel) after revision 1.3. I believe that are the changes you saw in nvmeinit.c.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Alex</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Parag Sheth [<a href="mailto:parag.sheth@avagotech.com">mailto:parag.sheth@avagotech.com</a>]
<br>
<b>Sent:</b> Tuesday, August 19, 2014 4:00 PM<br>
<b>To:</b> Alex Chang; <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> RE: [nvmewin] PMC Patch For SCSI Compliance Fixes And Others</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Alex,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">I noticed some changes in nvmeInit.c which are not related to the fixes you mentioned in the email below. I am comparing the patch against revision 1.3 source code.
</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Parag Sheth</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">
<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a> [mailto:<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a>]
<b>On Behalf Of </b>Alex Chang<br>
<b>Sent:</b> Friday, August 15, 2014 5:56 PM<br>
<b>To:</b> <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> [nvmewin] PMC Patch For SCSI Compliance Fixes And Others</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Hi all,<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">I am sending out this patch for your review/test. The password is pmc123. Please provide your feedback as soon as possible and I will start to collect approvals on August 27.<o:p></o:p></p>
<p class="MsoNormal">This patch contains the following changes:<o:p></o:p></p>
<p class="MsoNormal">1. Fixed compiling errors when configured as /W3 and /WX. (nvmestd.c, nvmesnti.c)<o:p></o:p></p>
<p class="MsoNormal">2. Fixed to use Windows 8/SRB Extension defined Storage Request Block for Windows 8 and up. (nvmestd.c)<o:p></o:p></p>
<p class="MsoNormal">3. Fixed the following SCSI Compliance test failures: (nvmesnti.c)<o:p></o:p></p>
<p class="MsoNormal">- Supporting Log Sense command.<o:p></o:p></p>
<p class="MsoNormal">- Log Sense (Temperature Page)<o:p></o:p></p>
<p class="MsoNormal">- Log Sense (Informational Exceptional Page)<o:p></o:p></p>
<p class="MsoNormal">- Inquiry (Standard Page)<o:p></o:p></p>
<p class="MsoNormal">- Inquiry (Device ID Page)<o:p></o:p></p>
<p class="MsoNormal">- Inquiry (Unit Serial Page)<o:p></o:p></p>
<p class="MsoNormal">- Read Capacity 16 (Need to take care of null CDB buffer)<o:p></o:p></p>
<p class="MsoNormal">- Unmap (Anchor bit is not supported)<o:p></o:p></p>
<p class="MsoNormal">4. Fixed Get Log Page building, it needs to be 0's based number of DWORDs specified in DWORD 10 (nvmesnti.c).<o:p></o:p></p>
<p class="MsoNormal">5. Fixed a Report LUN bug that reports a zero-sized namespace when Namespace IDs are not contiguous (nvmesnti.c).<o:p></o:p></p>
<p class="MsoNormal">6. Fixed Flush command related bug that requires correct Namespace ID specified (nvmesnti.c).<o:p></o:p></p>
<p class="MsoNormal">7. Fixed system crash on Windows 8 and up when accessing CDB buffer in IO_StorPortNotification (nvmestd.c).<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Unit Tests:<o:p></o:p></p>
<p class="MsoNormal">Tested the following on Windows 7, Server 2008, 8 and Server 2012:<o:p></o:p></p>
<p class="MsoListParagraph">-<span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>Ran SCSI compliance tests<o:p></o:p></p>
<p class="MsoListParagraph">-<span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>Ran SDStress<o:p></o:p></p>
<p class="MsoListParagraph">-<span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>Ran IOmeter<o:p></o:p></p>
<p class="MsoListParagraph">-<span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>Disk format (quick and slow) as MBR and GPT drive<o:p></o:p></p>
<p class="MsoListParagraph">-<span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>Install/Uninstall, Enable/Disable driver<o:p></o:p></p>
<p class="MsoNormal">In addition, I also ran the NVMe SCSI Compliance Test using HCK 8.100.26795 on Windows 8.1 without any errors (see the attached results).<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Thank you and have a great weekend!<o:p></o:p></p>
<p class="MsoNormal">Alex<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</body>
</html>