<HTML xmlns:o = "urn:schemas-microsoft-com:office:office"><HEAD><TITLE>Samsung Enterprise Portal mySingle</TITLE>
<META content=IE=5 http-equiv=X-UA-Compatible>
<META content="text/html; charset=windows-1252" http-equiv=Content-Type>
<STYLE id=mysingle_style type=text/css>P {
MARGIN-BOTTOM: 5px; FONT-SIZE: 9pt; FONT-FAMILY: Arial, arial; MARGIN-TOP: 5px
}
TD {
MARGIN-BOTTOM: 5px; FONT-SIZE: 9pt; FONT-FAMILY: Arial, arial; MARGIN-TOP: 5px
}
LI {
MARGIN-BOTTOM: 5px; FONT-SIZE: 9pt; FONT-FAMILY: Arial, arial; MARGIN-TOP: 5px
}
BODY {
FONT-SIZE: 9pt; FONT-FAMILY: Arial, arial; MARGIN: 10px; LINE-HEIGHT: 1.4
}
</STYLE>
<META name=GENERATOR content=ActiveSquare></HEAD>
<BODY>
<P><FONT color=#1f497d face=Calibri>Hi Alex,</FONT></P>
<P><FONT color=#1f497d face=Calibri></FONT> </P>
<P><FONT color=#1f497d face=Calibri>Please find attached the revised code with the following review comments incorporated. Password is <STRONG><SPAN style="COLOR: #0000ff">samsung123</SPAN></STRONG>.</FONT></P>
<P><FONT color=#1f497d face=Calibri></FONT> </P>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'>1. In function NVMeWaitForCtrlRDY(), you return TRUE when device is removed. And as per your explanation, this is to avoid delay in removing device from device manager. But returning TRUE is not intuitive. This function actually failed and hence we should be returning FALSE. And if this breaks your flow than the max delay would be 500 milliseconds. I would say that is negligible from user display point of view.<o:p></o:p></P>
<P><FONT color=#1f497d face=Calibri>a. Moved the pAE->ShutdownInProgress inside the else part in NVMeAdapterControlPowerDown().<BR>b. Returned FALSE from NVMeWaitForCtrlRDY() when device is removed.</FONT></P>
<P><FONT color=#1f497d face=Calibri></FONT> </P>
<P><FONT color=#1f497d face=Calibri><FONT color=#000000 face="Times New Roman">2. Function brief needs to be updated for NVMeDetectPendingCmds() for the 3rd parameter.</FONT><BR>Function brief updated for NVMeDetectPendingCmds() for the 3rd parameter.</FONT></P>
<P><FONT color=#1f497d face=Calibri></FONT> </P>
<P><FONT color=#1f497d face=Calibri>Thanks,</FONT></P>
<P><FONT color=#1f497d face=Calibri>Suman</FONT></P>
<P class=MsoNormal><SPAN style='FONT-SIZE: 11pt; FONT-FAMILY: "Calibri","sans-serif"; COLOR: #1f497d'></SPAN> </P>
<P class=MsoNormal><SPAN style='FONT-SIZE: 11pt; FONT-FAMILY: "Calibri","sans-serif"; COLOR: #1f497d'></SPAN> </P><o:p>
<P>------- <B>Original Message</B> -------</P>
<P><B>Sender</B> : Alex Chang<Alex.Chang@pmcs.com></P>
<P><B>Date</B> : Nov 15, 2014 03:36 (GMT+05:00)</P>
<P><B>Title</B> : RE: Re: [nvmewin] Samsung patch for Hot plug fixes</P>
<P> </P>
<P class=MsoNormal>
<META name=Generator content=ActiveSquare>
<STYLE>v\:* {
BEHAVIOR: url(#default#VML)
}
o\:* {
BEHAVIOR: url(#default#VML)
}
w\:* {
BEHAVIOR: url(#default#VML)
}
.shape {
BEHAVIOR: url(#default#VML)
}
</STYLE>
<STYLE>@font-face {
font-family: SimSun;
}
@font-face {
font-family: SimSun;
}
@font-face {
font-family: Calibri;
}
@font-face {
font-family: Tahoma;
}
@font-face {
font-family: Consolas;
}
@font-face {
font-family: @SimSun;
}
@page WordSection1 {size: 8.5in 11.0in; margin: 1.0in 1.0in 1.0in 1.0in; }
P.MsoNormal {
FONT-SIZE: 12pt; FONT-FAMILY: "Times New Roman","serif"; MARGIN: 0in 0in 0pt
}
LI.MsoNormal {
FONT-SIZE: 12pt; FONT-FAMILY: "Times New Roman","serif"; MARGIN: 0in 0in 0pt
}
DIV.MsoNormal {
FONT-SIZE: 12pt; FONT-FAMILY: "Times New Roman","serif"; MARGIN: 0in 0in 0pt
}
A:link {
TEXT-DECORATION: underline; COLOR: blue; mso-style-priority: 99
}
SPAN.MsoHyperlink {
TEXT-DECORATION: underline; COLOR: blue; mso-style-priority: 99
}
A:visited {
TEXT-DECORATION: underline; COLOR: purple; mso-style-priority: 99
}
SPAN.MsoHyperlinkFollowed {
TEXT-DECORATION: underline; COLOR: purple; mso-style-priority: 99
}
P {
FONT-SIZE: 12pt; FONT-FAMILY: "Times New Roman","serif"; MARGIN-LEFT: 0in; MARGIN-RIGHT: 0in; mso-style-priority: 99; mso-margin-top-alt: auto; mso-margin-bottom-alt: auto
}
PRE {
FONT-SIZE: 10pt; FONT-FAMILY: "Courier New"; MARGIN: 0in 0in 0pt; mso-style-priority: 99; mso-style-link: "HTML Preformatted Char"
}
SPAN.HTMLPreformattedChar {
FONT-FAMILY: Consolas; mso-style-priority: 99; mso-style-link: "HTML Preformatted"; mso-style-name: "HTML Preformatted Char"
}
SPAN.EmailStyle21 {
FONT-FAMILY: "Calibri","sans-serif"; COLOR: #1f497d; mso-style-type: personal-reply
}
.MsoChpDefault {
FONT-FAMILY: "Calibri","sans-serif"; mso-style-type: export-only
}
DIV.WordSection1 {
page: WordSection1
}
</STYLE>
<X-BODY lang=EN-US link="blue" vlink="purple"></P>
<DIV style="TEXT-DECORATION: ; FONT-FAMILY: ; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ">
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><SPAN style='FONT-SIZE: 11pt; FONT-FAMILY: "Calibri","sans-serif"; COLOR: rgb(31,73,125)'>Hi Suman,<o:p></o:p></SPAN></P>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><SPAN style='FONT-SIZE: 11pt; FONT-FAMILY: "Calibri","sans-serif"; COLOR: rgb(31,73,125)'><o:p> </o:p></SPAN></P>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><SPAN style='FONT-SIZE: 11pt; FONT-FAMILY: "Calibri","sans-serif"; COLOR: rgb(31,73,125)'>Could you please revise the codes, test and send it out at your earliest convenience?<o:p></o:p></SPAN></P>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><SPAN style='FONT-SIZE: 11pt; FONT-FAMILY: "Calibri","sans-serif"; COLOR: rgb(31,73,125)'><o:p> </o:p></SPAN></P>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><SPAN style='FONT-SIZE: 11pt; FONT-FAMILY: "Calibri","sans-serif"; COLOR: rgb(31,73,125)'>Thank you!<o:p></o:p></SPAN></P>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><SPAN style='FONT-SIZE: 11pt; FONT-FAMILY: "Calibri","sans-serif"; COLOR: rgb(31,73,125)'>Alex<o:p></o:p></SPAN></P>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><SPAN style='FONT-SIZE: 11pt; FONT-FAMILY: "Calibri","sans-serif"; COLOR: rgb(31,73,125)'><o:p> </o:p></SPAN></P>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><B><SPAN style='FONT-SIZE: 10pt; FONT-FAMILY: "Tahoma","sans-serif"'>From:</SPAN></B><SPAN style='FONT-SIZE: 10pt; FONT-FAMILY: "Tahoma","sans-serif"'> Parag Sheth [mailto:parag.sheth@seagate.com] <BR><B>Sent:</B> Friday, November 14, 2014 1:56 PM<BR><B>To:</B> suman.p@samsung.com<BR><B>Cc:</B> Alex Chang; nvmewin@lists.openfabrics.org; judy.brock@ssi.samsung.com<BR><B>Subject:</B> Re: Re: [nvmewin] Samsung patch for Hot plug fixes<o:p></o:p></SPAN></P>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><o:p> </o:p></P>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'>Hi Suman,<o:p></o:p></P>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><o:p> </o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'>As long as this change passes all your test cases - I am ok with that.<o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><o:p> </o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'>Thanks<o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'>Parag Sheth<o:p></o:p></P></DIV></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><o:p> </o:p></P>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'>On Fri, Nov 14, 2014 at 12:40 AM, SUMAN PRAKASH B <<A href="mailto:suman.p@samsung.com" target=_blank>suman.p@samsung.com</A>> wrote:<o:p></o:p></P>
<DIV>
<P>Hi Parag,<o:p></o:p></P>
<P> <o:p></o:p></P>
<P>Thanks for your feedback. Please find my comments inline.<o:p></o:p></P>
<P> <o:p></o:p></P>
<P>Thanks,<o:p></o:p></P>
<P>Suman<o:p></o:p></P>
<P> <o:p></o:p></P>
<P>------- <B>Original Message</B> -------<o:p></o:p></P>
<P><B>Sender</B> : Parag Sheth<<A href="mailto:parag.sheth@seagate.com" target=_blank>parag.sheth@seagate.com</A>><o:p></o:p></P>
<P><B>Date</B> : Nov 14, 2014 06:31 (GMT+05:00)<o:p></o:p></P>
<P><B>Title</B> : Re: [nvmewin] Samsung patch for Hot plug fixes<o:p></o:p></P>
<P> <o:p></o:p></P>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'>Hi Suman, <o:p></o:p></P>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><o:p> </o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'>Here are my observations<o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><o:p> </o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'>1. In function NVMeWaitForCtrlRDY(), you return TRUE when device is removed. And as per your explanation, this is to avoid delay in removing device from device manager. But returning TRUE is not intuitive. This function actually failed and hence we should be returning FALSE. And if this breaks your flow than the max delay would be 500 milliseconds. I would say that is negligible from user display point of view.<o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><STRONG><SPAN style="COLOR: blue">[Suman] </SPAN></STRONG><SPAN style="COLOR: blue">Agreed. We initially returned FALSE from NVMeWaitForCtrlRDY() when device is removed. We changed it to TRUE for the following reason.</SPAN><o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><SPAN style="COLOR: blue">When device is removed, the NVMeBuildIo() -> SRB_FUNCTION_PNP -> NVMeAdapterControlPowerDown() -> NVMeResetAdapter() -> NVMeWaitForCtrlRDY() was returning FALSE because of which the pAE->ShutdownInProgess was not set to TRUE in NVMeAdaptercontrolPowerDown. <BR>After this when NVMeAdapterControl() -> ScsiStopAdapter -> NVMeAdapterControlPowerDown() is invoked, since the pAE->ShutdownInProgess was not set to TRUE in NVMeBuildIo(), the NVMeDetectPendingCmds() and NVMeResetAdapter() is executed again. This should not be executed second time.<BR>To avoid this we retured TRUE from NVMeWaitForCtrlRDY() so that pAE->ShutdownInProgress is set to TRUE.</SPAN><o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'> <o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><SPAN style="COLOR: blue">To resolve this, in NVMeAdapterControlPowerDown(), we can move setting the pAE->ShutdownInProgress inside the else part and return FALSE when device is removed from NVMeWaitForCtrlRDY() as follows.</SPAN><o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><SPAN style="COLOR: blue">NVMeAdapterControlPowerDown()<BR>{<BR>...<BR> if (pAE->ShutdownInProgress == TRUE) {<BR> /* Shutdown */<BR> status = TRUE;<BR> } else {<BR> <SPAN style="BACKGROUND: yellow">pAE->ShutdownInProgress = TRUE;</SPAN></SPAN><o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><SPAN style="COLOR: blue"> /* Hibernate or Sleep - sanity check that there is no cmd pending */<BR> if (NVMeDetectPendingCmds(pAE, FALSE, SRB_STATUS_BUS_RESET) == TRUE)<BR> return status;</SPAN><o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><SPAN style="COLOR: blue"> /* Stop the controller, but do not free the resources */<BR> if (NVMeResetAdapter(pAE) != TRUE) {<BR> return (FALSE);<BR> }<BR> }<BR>...<BR>}</SPAN><o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><SPAN style="COLOR: blue">Kindly let us know your opinion.</SPAN><o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><BR> <o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'>2. Function brief needs to be updated for NVMeDetectPendingCmds() for the 3rd parameter.<o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><STRONG><SPAN style="COLOR: blue">[Suman] </SPAN></STRONG><SPAN style="COLOR: blue">Yes. We will change this.</SPAN><o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><BR> <o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'>Other than these 2, your changes look good.<o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'><o:p> </o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'>Thanks<o:p></o:p></P></DIV>
<DIV>
<P style='MARGIN-BOTTOM: 0pt; FONT-SIZE: 12pt; TEXT-DECORATION: ; FONT-FAMILY: "Times New Roman","serif"; BORDER-TOP-COLOR: ; BORDER-LEFT-COLOR: ; COLOR: ; BORDER-BOTTOM-COLOR: ; BORDER-RIGHT-COLOR: ; MARGIN-RIGHT: 0in'>Parag Sheth<o:p></o:p></P></DIV></DIV></DIV></DIV></DIV></DIV></o:p><!--SP:suman.p--><!--suman.p:EP-->
<P> </P>
<TABLE id=confidentialsignimg>
<TBODY>
<TR>
<TD NAMO_LOCK>
<P><IMG border=0 src="cid:A6X7LP7KBSL8@namo.co.kr"></P></TD></TR></TBODY></TABLE></BODY></HTML><img src='http://ext.samsung.net/mailcheck/SeenTimeChecker?do=daca5f29ec351d6708b869fc34b1bd6a0f06ade1fb60e9817d9badbdf7e30042d1afaaba7860cdcd9564217c646641ad61e16949eaa607501b20909a04efd4d2748cfe1d4e847419cf878f9a26ce15a0' border=0 width=0 height=0 style='display:none'>